Repository navigation
fix(i18n): add translation keys for first day of the week preference - #9985
Open
Indira-kumar wants to merge 1 commit into
Open
Indira-kumar wants to merge 1 commit into
Indira-kumar wants to merge 1 commit into
Conversation
|
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The localization changes have no identified merge-blocking issue. The Italian wording concern predates this change; the updated weekday selectors use the translated labels. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 6 files. (21 skipped: 2… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Title check The title clearly identifies the main change: adding translation keys for the first-day-of-week preference. Description check The description covers the change, change type, screenshot, test scenarios, and references. It is sufficiently complete and matches the pull request objectives. Linked Issues check Issues #9966and#9967require Spanish translations for the first-day-of-week title, description, and seven weekday options. The preferences page now uses `account_settings.preferences.first_day_of_we…Out of Scope Changes check The changes stay within the localization scope of issues #9966and#9967. Component changes consume translation keys, constants identify translated weekday labels, locale files provide the copy, and t…
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 6 files. (21 skipped: 21 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Localize the “First day of the week” preference title, description, and weekday options across supported languages. Use the existing translation-key pattern in both Preferences and the command menu.
Type of Change
Screenshots and Media
Test Scenarios
References
Closes #9966
Closes #9967 (realized later there is a duplicate issue for #9966)
Note: OxLint, all six changed TypeScript files pass with zero warnings and zero errors
Summary by CodeRabbit