Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #215.
With this PR nested splits no longer recurse. The outermost split keeps the pending halves on an explicit stack and
triangulates them in a loop. Halves come off it in the same depth-first order as before, so the output is the same, in
the same order.
earcut()andearcutLinkedare unchanged, and the new code runs only after a split diagonal hasbeen found.
--stack-size=7000bench/bench-tiles.js, median of 6 runsThe output is also identical to main's on the test fixtures, all polygons of
bench/tiles-fixture.binand about228,000 random polygons. The new test runs in a worker with a 0.35 MB stack, so that it overflows on main quickly and
reliably.