Repository navigation
highlight: Color call names blue instead of bold - #50
Merged
Merged
Conversation
On a dark theme most terminals draw bold as bright white, so the call or event name at the start of every line was the brightest thing on screen, louder than the arguments it introduces. Blue keeps it distinct from the strings, numbers and constants that follow, at their weight, and still follows the terminal's palette.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a dark theme most terminals draw bold as bright white, so the call/event name at the start of every traced line was the brightest thing on screen, louder than the arguments it introduces. This colors it blue (
\x1b[34m) at regular weight instead: still distinct from the green strings, cyan numbers and yellow constants that follow, and still one of the terminal's 16 basic colors, so it follows the user's theme.