Repository navigation
Select parse-live's events in one place for this Mac and pymobiledevice3 - #53
Merged
Merged
Conversation
Move pymobiledevice3's parse-live selection here, so this Mac's parse-live and a device's select the same events the same way: `parse_live_selection` (the classes, subclasses and ids its options select, adding up), `captured_events` (the names it prints for them), the user space event groups (`--xpc`, `--dispatch`, `--runloop`, by trace code name prefix), and the help of each group. `--fs` gains the guarded opens (guarded_open_np, guarded_open_dprotected_np), which SQLite opens its databases, journals and shared memory with, as pymobiledevice3's already does.
…ce3's parse-live gains --xpc, --dispatch and --runloop, and its selection options and their help are pymobiledevice3's. `events` takes the same options and lists the events parse-live prints with them (`events --fs`, `events -s open`), or finds a name (`events dlsym`), replacing `syscalls --group`, as pymobiledevice3 did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes this Mac's
parse-liveand pymobiledevice3'sparse-live(a device) select events with one implementation, so the two can't drift apart. They already had: 1.7.0's--fslacked the guarded opens pymobiledevice3 prints, and it had no--xpc/--dispatch/--runloopand a differentevents.pykdebugparser.selection(moved from pymobiledevice3):parse_live_selection(bsc=, class_filters=, subclass_filters=, syscalls=, events=, groups=, dyld=)returns the classes, subclasses and ids the options select. Everything adds up.captured_events(selection)returns the namesparse-liveprints for a selection: the ones selected by id, plus the decoded events of the selected classes and subclasses.GROUPSandGROUP_HELPhold every group and its option help.trace_codes:--fsgainsguarded_open_npandguarded_open_dprotected_np, which SQLite opens its databases, journals and shared memory with.EVENT_GROUP_PREFIXES,group_eventsandparsed_events.CLI:
parse-livegains--xpc,--dispatchand--runloop, and its selection options and help match pymobiledevice3's.events [TEXT]now takes the same options and lists whatparse-liveprints with them, replacingsyscalls --groupthe same way pymobiledevice3 did:Checked:
--bsc,--dyld,-s,-e,-cf 0x29,-sf 0x40c, and a mix), this selection and pymobiledevice3's current one give identical classes, subclasses, ids andcaptured_events.parse-live --xpcprints libxpc events (XPC_connection_send_message, ...).pymobiledevice3 will import all of this once it's released.