Repository navigation
MSC4140: manage delayed events through an authenticated client - #924
Merged
anoadragon453 merged 1 commit intoOct 8, 2026
Merged
Conversation
This was referenced Sep 23, 2026
MSC4140 describes the delayed event management endpoints
(POST /delayed_events/{delay_id}/{cancel,restart,send}) as authenticated,
and scopes them to the requesting user. Make every management call on
a real delay ID, and the negative tests on an unknown delay ID, go
through the user who scheduled the event instead of the unauthenticated
client.
The only unauthenticated call left is the one asserting that the bulk
GET answers 401 without a token.
Signed-off-by: Paul Chobert <paul@chobert.fr>
barodeur
force-pushed
the
msc4140-authenticated-management
branch
from
October 6, 2026 13:54
9d1df56 to
e07d00a
Compare
barodeur
marked this pull request as ready for review
October 8, 2026 09:28
anoadragon453
approved these changes
Oct 8, 2026
anoadragon453
left a comment
anoadragon453
left a comment
Member
There was a problem hiding this comment.
This updates the tests to match the merged version of MSC4140.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR can be merged before element-hq/synapse#20257
This is a sister PR to element-hq/synapse#20257
Delayed Event (MSC4140) management endpoint should be authenticated.
This PR modifies the existing test to send authenticated requests.
Signed-off-by: Paul Chobert paul@chobert.fr