Repository navigation
Fix depth-axis clipping in quick look plots caused by _grid_dims() rounding down - #207
Merged
Merged
Conversation
…unding down _grid_dims() rounded the computed max_depth down to the nearest 10m and could silently exclude a plotted variable from the max-depth calculation based on its dimension name, both of which clipped legitimate, already-QC'd depth data off the bottom of the color-shaded plots. Round up instead, and use a direct shape comparison for variable inclusion. Adds test_create_products.py, which had no prior coverage. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_grid_dims() rounded the computed max_depth down to the nearest 10m and could silently exclude a plotted variable from the max-depth calculation based on its dimension name, both of which clipped legitimate, already-QC'd depth data off the bottom of the color-shaded plots. Round up instead, and use a direct shape comparison for variable inclusion. Adds test_create_products.py, which had no prior coverage.