Repository navigation
Clamp RecordsAffected to int.MaxValue instead of throwing - #28
Open
francoisjehl wants to merge 1 commit into
Open
francoisjehl wants to merge 1 commit into
francoisjehl wants to merge 1 commit into
Conversation
francoisjehl
requested review from
okramarenko and
pmishchenko-ua
as code owners
October 14, 2026 12:59
PR SummaryLow Risk Overview A regression test runs Reviewed by Cursor Bugbot for commit 4576eb6. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
On DDL like
ALTER TABLE ADD COLUMN, SingleStore reports the table's row count as affected rows.Issue is, this is 32 bits in ADO.NET and thus once a table passes 2^31 rows, it throws
OverflowException.We faced that at Pigment on a 4B row table.
Implementation
(int) Math.Min(recordsAffected, int.MaxValue). This keeps theintcontract ofDbDataReader.RecordsAffected, saturates instead of throwing, and documents the cap in the XML remarks.