Repository navigation
Preserve multi-metric outcome constraints through candidate generation - #5310
Closed
saitcakmak wants to merge 1 commit into
Closed
saitcakmak wants to merge 1 commit into
saitcakmak wants to merge 1 commit into
Conversation
Summary: Fixes meta#5309. What Changed: - Extract all signed coefficients from `OutcomeConstraint.metric_weights`, without depending on the deprecated `ScalarizedOutcomeConstraint` class. - Validate every fitted constraint metric and compute relative baseline values and diagnostics from every component. - Exclude scalarized constraints from automatic single-metric winsorization and avoid nonlinear `BilogY` transformations of their component metrics, including components that also have single-metric constraints. - Reject relative multi-metric expressions in the Client API parser, consistent with the existing documented restriction. Lower-level mixed-sign relative parsing remains a separate issue. - Add regression coverage for expression constraints, both inequality directions, signed coefficients, canonical signatures, relative baseline handling, missing component data, and end-to-end Client generation. The Client reproduction produced `A=[[0,1,0]]` before the fix. The regression now verifies both appropriately standardized metric coefficients and the transformed bound. Differential Revision: D126924134
meta-cla
Bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126924134. |
|
This pull request has been merged in 4cb6e3e. |
1 task done
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5310 +/- ##
==========================================
+ Coverage 96.60% 96.61% +0.01%
==========================================
Files 621 621
Lines 71099 71221 +122
==========================================
+ Hits 68683 68808 +125
+ Misses 2416 2413 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #5309.
What Changed:
OutcomeConstraint.metric_weights, without depending on the deprecatedScalarizedOutcomeConstraintclass.BilogYtransformations of their component metrics, including components that also have single-metric constraints.The Client reproduction produced
A=[[0,1,0]]before the fix. The regression now verifies both appropriately standardized metric coefficients and the transformed bound.Differential Revision: D126924134