Repository navigation
Fix VAT adjustment register - #13216
Open
Alexander Yakunin (Alexander-Ya) wants to merge 1 commit into
Open
Alexander Yakunin (Alexander-Ya) wants to merge 1 commit into
Alexander Yakunin (Alexander-Ya) wants to merge 1 commit into
Conversation
Alexander Yakunin (Alexander-Ya)
requested a review
from a team
as a code owner
October 23, 2026 14:37
Alexander Yakunin (Alexander-Ya)
deployed
to
triage
October 23, 2026 14:37 — with 
GitHub Actions
Active
GitHub Actions
Active
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| GenJournalLine.Validate("Pmt. Discount Date", WorkDate()); | ||
| GenJournalLine.Modify(true); | ||
| CreateGLAccountInvoiceGenJnlLine(GenJournalLine, GLAccountNo, -InvoiceSign * 1190); | ||
| LibraryERM.PostGeneralJnlLine(GenJournalLine); |
Contributor
There was a problem hiding this comment.
The new payment-discount tests post journal lines through the posting routine, which can call COMMIT, but the test methods do not declare TransactionModel::AutoCommit. Under the default AutoRollback model the tests can fail at the transaction boundary instead of producing a business-logic verdict; add the appropriate transaction model and ensure the test runner provides isolation for the committed writes.
Knowledge:
The same issue exists in these regional copies — apply the equivalent fix in each:
src/Layers/CZ/Tests/VAT/ERMPmtDiscAndVATCustVend.Codeunit.al:682(CZ)
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.51.6
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Linked work
Fixes AB#656025
How I validated this
What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)
Risk & compatibility