[FR] Redirect payment management pages based on feature state by ventselartur · Pull Request #13217 · microsoft/BCApps

ventselartur · 2026-10-23T14:46:24Z

Why

Opening either legacy or FR Payment Management entry links should select the implementation matching the Payment feature state instead of showing a feature-switch error or leaving users on the wrong page.

Summary

Add old-to-new redirects in the three FR BaseApp pages using numeric page IDs, without a compile-time dependency on PaymentManagementFR.
Redirect the FR pages back to legacy pages when the feature is disabled, and abort opening the original page without a visible error.
Remove the two redundant app-side page extensions.
Add four regression tests covering all twelve page/link/feature-state combinations.

Linked work

Fixes AB#656576

Route both legacy and FR entry links to the implementation selected by the Payment feature. Keep numeric forward redirects in BaseApp without adding an app dependency, retain reverse redirects in the FR app, and cover all page/state combinations. Fixes AB#656576 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6eae832b-7968-4b2c-8637-3b3465346541

github-actions · 2026-10-23T15:32:35Z

    begin
-        if not FeaturePaymentManagement.IsEnabled() then
-            Error(EnablePaymentManagementFRPageErr);
+        if not FeaturePaymentManagement.IsEnabled() then begin


$\textbf{🟠\ High\ Severity\ —\ Breaking\ Changes}$

New redirect behavior was added inside a #if not CLEAN28 block in the legacy Payment Report FR page. Code in a CLEAN-guarded obsolete region is scheduled for removal; move the feature-state routing to the supported replacement rather than extending this legacy path.

Knowledge:

microsoft/knowledge/breaking-changes/do-not-modify-code-already-marked-obsolete.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.51.6}

github-actions · 2026-10-23T15:32:37Z

        FRPaymentSlipTok: Label 'FR Create Payment Slips', Locked = true;
    begin
+#if not CLEAN28
+        if not FeaturePaymentManagement.IsEnabled() then begin


$\textbf{🟠\ High\ Severity\ —\ Breaking\ Changes}$

New redirect behavior was added inside a #if not CLEAN28 block in the legacy Payment Slip List FR page. Code in a CLEAN-guarded obsolete region is scheduled for removal; move the feature-state routing to the supported replacement rather than extending this legacy path.

Knowledge:

microsoft/knowledge/breaking-changes/do-not-modify-code-already-marked-obsolete.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.51.6}

github-actions · 2026-10-23T15:32:38Z

    begin
-        if not FeaturePaymentManagement.IsEnabled() then
-            Error(EnablePaymentManagementFRPageErr);
+        if not FeaturePaymentManagement.IsEnabled() then begin


$\textbf{🟠\ High\ Severity\ —\ Breaking\ Changes}$

New redirect behavior was added inside a #if not CLEAN28 block in the legacy View/Edit Payment Line FR page. Code in a CLEAN-guarded obsolete region is scheduled for removal; move the feature-state routing to the supported replacement rather than extending this legacy path.

Knowledge:

microsoft/knowledge/breaking-changes/do-not-modify-code-already-marked-obsolete.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.51.6}

github-actions · 2026-10-23T15:32:39Z

        }
    }
+
+    trigger OnOpenPage()


$\textbf{🟠\ High\ Severity\ —\ Breaking\ Changes}$

New redirect behavior was added to the Payment Report page, which is marked ObsoleteState = Pending and wrapped in #if not CLEAN28. Obsolete code is scheduled for removal; route callers through the supported replacement instead of extending this legacy page.

Knowledge:

microsoft/knowledge/breaking-changes/do-not-modify-code-already-marked-obsolete.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.51.6}

github-actions · 2026-10-23T15:32:41Z


    trigger OnOpenPage()
    var
+        FeatureKeyManagement: Codeunit "Feature Key Management";


$\textbf{🟠\ High\ Severity\ —\ Breaking\ Changes}$

New redirect behavior was added to the Payment Slip List page, which is marked ObsoleteState = Pending and wrapped in #if not CLEAN28. Obsolete code is scheduled for removal; route callers through the supported replacement instead of extending this legacy page.

Knowledge:

microsoft/knowledge/breaking-changes/do-not-modify-code-already-marked-obsolete.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.51.6}

github-actions · 2026-10-23T15:32:42Z

        }
    }
+
+    trigger OnOpenPage()


$\textbf{🟠\ High\ Severity\ —\ Breaking\ Changes}$

New redirect behavior was added to the View/Edit Payment Line page, which is marked ObsoleteState = Pending and wrapped in #if not CLEAN28. Obsolete code is scheduled for removal; route callers through the supported replacement instead of extending this legacy page.

Knowledge:

microsoft/knowledge/breaking-changes/do-not-modify-code-already-marked-obsolete.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.51.6}

github-actions · 2026-10-23T15:32:44Z

+#pragma warning disable AL0432
+            Page.Run(Page::"Payment Report");
+#pragma warning restore AL0432
+            Error('');


$\textbf{🟡\ Medium\ Severity\ —\ Privacy}$

The redirect terminator calls Error with a string literal rather than a Label or TextConst. RT0030 Error method telemetry therefore receives generic guidance instead of a stable, classified error message.

Knowledge:

microsoft/knowledge/privacy/error-vs-message-telemetry-logging.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.51.6}

github-actions · 2026-10-23T15:32:45Z

+#pragma warning disable AL0432
+            Page.Run(Page::"Payment Slip List");
+#pragma warning restore AL0432
+            Error('');


$\textbf{🟡\ Medium\ Severity\ —\ Privacy}$

The redirect terminator calls Error with a string literal rather than a Label or TextConst. RT0030 Error method telemetry therefore receives generic guidance instead of a stable, classified error message.

Knowledge:

microsoft/knowledge/privacy/error-vs-message-telemetry-logging.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.51.6}

github-actions · 2026-10-23T15:32:47Z

+#pragma warning disable AL0432
+            Page.Run(Page::"View/Edit Payment Line");
+#pragma warning restore AL0432
+            Error('');


$\textbf{🟡\ Medium\ Severity\ —\ Privacy}$

The redirect terminator calls Error with a string literal rather than a Label or TextConst. RT0030 Error method telemetry therefore receives generic guidance instead of a stable, classified error message.

Knowledge:

microsoft/knowledge/privacy/error-vs-message-telemetry-logging.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.51.6}

github-actions · 2026-10-23T15:32:48Z

+    begin
+        if FeatureKeyManagement.IsPaymentManagementEnabled() then begin
+            Page.Run(10841); // Payment Report FR
+            Error('');


$\textbf{🟡\ Medium\ Severity\ —\ Privacy}$

The redirect terminator calls Error with a string literal rather than a Label or TextConst. RT0030 Error method telemetry therefore receives generic guidance instead of a stable, classified error message.

Knowledge:

microsoft/knowledge/privacy/error-vs-message-telemetry-logging.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.51.6}

github-actions · 2026-10-23T15:32:49Z

    begin
+        if FeatureKeyManagement.IsPaymentManagementEnabled() then begin
+            Page.Run(10846); // Payment Slip List FR
+            Error('');


$\textbf{🟡\ Medium\ Severity\ —\ Privacy}$

The redirect terminator calls Error with a string literal rather than a Label or TextConst. RT0030 Error method telemetry therefore receives generic guidance instead of a stable, classified error message.

Knowledge:

microsoft/knowledge/privacy/error-vs-message-telemetry-logging.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.51.6}

github-actions · 2026-10-23T15:32:51Z

+    begin
+        if FeatureKeyManagement.IsPaymentManagementEnabled() then begin
+            Page.Run(10857); // View/Edit Payment Line FR
+            Error('');


$\textbf{🟡\ Medium\ Severity\ —\ Privacy}$

The redirect terminator calls Error with a string literal rather than a Label or TextConst. RT0030 Error method telemetry therefore receives generic guidance instead of a stable, classified error message.

Knowledge:

microsoft/knowledge/privacy/error-vs-message-telemetry-logging.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.51.6}

github-actions · 2026-10-23T15:32:52Z

+        FeatureKeyManagement: Codeunit "Feature Key Management";
+    begin
+        if FeatureKeyManagement.IsPaymentManagementEnabled() then begin
+            Page.Run(10841); // Payment Report FR


$\textbf{🟡\ Medium\ Severity\ —\ Style}$

The page is invoked by numeric object ID 10841. Use the named selector Page::"Payment Report FR" so the call remains readable and resilient to object renumbering or renaming.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

Page.Run(Page::"Payment Report FR"); // Payment Report FR

Knowledge:

microsoft/knowledge/style/named-invocations-not-object-ids.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.51.6}

github-actions · 2026-10-23T15:32:54Z

        FRPaymentSlipTok: Label 'FR Create Payment Slips', Locked = true;
    begin
+        if FeatureKeyManagement.IsPaymentManagementEnabled() then begin
+            Page.Run(10846); // Payment Slip List FR


$\textbf{🟡\ Medium\ Severity\ —\ Style}$

The page is invoked by numeric object ID 10846. Use the named selector Page::"Payment Slip List FR" so the call remains readable and resilient to object renumbering or renaming.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

Page.Run(Page::"Payment Slip List FR"); // Payment Slip List FR

Knowledge:

microsoft/knowledge/style/named-invocations-not-object-ids.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.51.6}

github-actions · 2026-10-23T15:32:55Z

+        FeatureKeyManagement: Codeunit "Feature Key Management";
+    begin
+        if FeatureKeyManagement.IsPaymentManagementEnabled() then begin
+            Page.Run(10857); // View/Edit Payment Line FR


$\textbf{🟡\ Medium\ Severity\ —\ Style}$

The page is invoked by numeric object ID 10857. Use the named selector Page::"View/Edit Payment Line FR" so the call remains readable and resilient to object renumbering or renaming.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

Page.Run(Page::"View/Edit Payment Line FR"); // View/Edit Payment Line FR

Knowledge:

microsoft/knowledge/style/named-invocations-not-object-ids.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.51.6}

ventselartur deployed to triage October 23, 2026 14:46 — with GitHub Actions Active

github-actions Bot added the Team: Finance GitHub request for Finance area label Oct 23, 2026

github-actions Bot added this to the Version 30.0 milestone Oct 23, 2026

ventselartur marked this pull request as ready for review October 23, 2026 15:14

ventselartur deployed to triage October 23, 2026 15:14 — with GitHub Actions Active

github-actions Bot reviewed Oct 23, 2026

View reviewed changes

Conversation

ventselartur commented Oct 23, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

Summary

Linked work

Uh oh!

github-actions Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ventselartur commented Oct 23, 2026 •

edited by github-actions Bot

Loading