Repository navigation
Fix .NET Standard common name matching build - #216
Merged
Merged
Conversation
Use the .NET Standard 2.0-compatible IndexOf overload while preserving ordinal substring matching semantics. Add positive substring regression coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
elantiguamsft
approved these changes
Sep 24, 2026
Shawn Z. (NN2000X)
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
string.Contains(string, StringComparison)with the .NET Standard 2.0-compatibleIndexOfoverloadsigntool.exe /nsubstring semanticsRoot cause
The
Containsoverload used byX509CommonNameValidatoris not available in the .NET Standard 2.0 reference surface used by the zipped-source release build, producing CS1501.Validation
CoseSign1.CertificatesRelease build targetingnetstandard2: passedCoseSign1.Certificates.Tests: 147 passed, 0 failedFollow-up to #215 and the 1.7.9 release build failure.