Repository navigation
fix(tests): place v2 Pester tests inside the Hidi test project - #895
Merged
Gavin Barron (gavinbarron) merged 2 commits intoOct 9, 2026
Merged
Gavin Barron (gavinbarron) merged 2 commits into
Gavin Barron (gavinbarron) merged 2 commits into
Conversation
Link the existing Pester script into the Hidi test project so analysis treats it as test code without excluding files or changing release behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f8d164a5-72a6-482a-8749-ae5c6e47a0e5
Gavin Barron (gavinbarron)
marked this pull request as draft
October 9, 2026 18:02
Gavin Barron (gavinbarron)
changed the title
Move the existing script unchanged into the physical test project directory so the scanner assigns it to test sources. Remove the ineffective sibling link and update the workflow and local test documentation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f8d164a5-72a6-482a-8749-ae5c6e47a0e5
Gavin Barron (gavinbarron)
changed the title
|
Gavin Barron (gavinbarron)
marked this pull request as ready for review
October 9, 2026 18:33
Peter Ombwa (peombwa)
approved these changes
Oct 9, 2026
Gavin Barron (gavinbarron)
deleted the
gavinbarron-v2-pester-test-classification
branch
October 9, 2026 22:26
12 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
test/scripts/check-nuget-package-published.Tests.ps1unchanged intotest/Microsoft.OpenApi.Hidi.Tests/check-nuget-package-published.Tests.ps1, and update the SonarCloud execution path and README invocation/ownership explanation. Remove the earlier ineffective sibling link; the test project now owns the script through defaultNoneitems. Net PR diff: three files, including a 100% identical-content rename.SonarScanner 11.3.0 selects physical project ownership, not MSBuild Link metadata. The previous linked-sibling candidate was disproven by full remote evidence (
FIL, 76 uncovered lines). This physical relocation replaces it without manual source/test scopes, exclusions, fabricated coverage, or threshold changes.Accepted #893 ESRPRelease@14 behavior, helper/test bodies, Docker restore, net10.0, package versions, publishing flags, gates, and canonical ancestry remain unchanged.
Head:
4795eb0044ddebddeb1e2b100430666c31dbe43c; target:support/v2.Verified current-head remote evidence
test/Microsoft.OpenApi.Hidi.Tests/check-nuget-package-published.Tests.ps1asUTS, languagepowershell. It is present as a test component, not merely missing from production metrics.OK. The test contributes zero new coverable/uncovered lines. A green gate alone was not used as classification proof.Local ownership and unchanged-file evidence
0862f728101ec52e6597783ae81675628f2ebfcbexactly matches accepted v2 content;../../scriptsstill resolves the same production helper.IsTestProject=true,TargetFramework=net10.0, default physicalNoneownership withoutLink.Test, with Pester in FilesToAnalyze/test module. Generated properties assign Pester only toFD80F7C1-F1E6-45AE-AE6B-08B066757AD5.sonar.tests; helper only to rootsonar.sources. Existing C#Services/OpenApiServiceTests.csretains the same test module.support/v2branch analysis reports helperFIL, total coverage 100%, 38 lines to cover, zero uncovered, and C#OpenApiServiceTests.csasUTS. These branch totals are baseline evidence, not misrepresented as current PR-head metrics; current-head measured helper coverage is established by this PR's scanner-run logs above.Review and release boundaries
Ready for normal review; all current-head checks passed and the draft hold was removed after the explicit test-classification proof. Required codeowner approval remains outstanding. No merge or auto-merge requested. No additional analysis dispatch, production publishing, authorization changes, or local analysis upload occurred. Existing official release authorization remains an external gate; no signed-artifact or production-readiness claim is made.