Repository navigation
refactor(hidi): remove migrated v2 tool resources - #3109
Merged
Vincent Biret (baywet) merged 2 commits intoOct 9, 2026
Merged
Conversation
Follow accepted OpenAPI.NET.OData support/v2 import PR883. Retain core/YAML builds, signing, packaging and history; point hidi documentation to its new home. Publishing handoff remains gated pending destination official pipeline onboarding. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c631d217-9378-4cee-8c7e-761043ff3ae5
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall line coverage in commit c6717bb in the Show a line coverage summary of the most impacted files.
Updated |
Vincent Biret (baywet)
requested changes
Oct 9, 2026
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
Vincent Biret (baywet)
approved these changes
Oct 9, 2026
Vincent Biret (baywet)
marked this pull request as ready for review
October 9, 2026 14:48
Vincent Biret (baywet)
enabled auto-merge (squash)
October 9, 2026 14:48
|
6 of 19 tasks
12 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request
Description
Remove the active Hidi resources from OpenAPI.NET's
support/v2branch after the history-preserving destination migration was accepted in microsoft/OpenAPI.NET.OData#883.The destination PR merged normally at
516f5b58f2f3d86901d7da8f171e4c08a52c5edc. This cleanup is based on source1344a43fb823fea5b48d78e2aca4e3a1eff9221a; it does not rewrite source history or change library APIs or package versions.The migration coordinator verified the canonical imported commit
abd668c6and all 1,199 shared rewritten history objects are reachable on the destination branch.Type of Change
Related Issue(s)
Follow-up to microsoft/OpenAPI.NET.OData#883.
Changes Made
install-tool.ps1.RepoFilesartifacts/variables, and the GitHub release-edit job whose only assets were Hidi executables. Keep core/YAML packing and both ESRP signing steps. Select onlyMicrosoft.OpenApi.[0-9]*.nupkgfor core publishing instead of deleting other packages; preserve the separate YAML reader deployment and its dependency on core.support/v2branch.Testing
The coordinator executed the .NET and package checks in this worktree before committing and pushing
67c832d1c85dbea8ca519971b01ff15a2f7e385c.dotnet build Microsoft.OpenApi.slnx -c Release -v quiet: passed with 0 warnings and 0 errors.dotnet test --solution Microsoft.OpenApi.slnx -c Release --no-build -v minimal: passed, 1,508/1,508 remaining core/readers tests. The original source baseline passed 1,562 tests; the difference is exactly the 54 migrated Hidi tests.dotnet pack src\Microsoft.OpenApi\Microsoft.OpenApi.csproj -c Release --no-build -o C:\Users\gavinbarron\.copilot\session-state\c631d217-9378-4cee-8c7e-761043ff3ae5\files\source-v2-cleanup-packages --include-symbols --include-source /p:SymbolPackageFormat=snupkg: passed.dotnet pack src\Microsoft.OpenApi.YamlReader\Microsoft.OpenApi.YamlReader.csproj -c Release --no-build -o C:\Users\gavinbarron\.copilot\session-state\c631d217-9378-4cee-8c7e-761043ff3ae5\files\source-v2-cleanup-packages --include-symbols --include-source /p:SymbolPackageFormat=snupkg: passed.Microsoft.OpenApi.2.12.2.nupkg,Microsoft.OpenApi.2.12.2.snupkg,Microsoft.OpenApi.YamlReader.2.12.2.nupkg, andMicrosoft.OpenApi.YamlReader.2.12.2.snupkg; no Hidi package.go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.7 -shellcheck= -pyflakes= .github\workflows\codeql-analysis.yml: passed.git diff --check: passed.ConvertFrom-Jsonon all three.vscodeJSONC files, XML checks of every remaining solution project and ProjectReference, and PowerShell AST parsing of all five embedded pipeline scripts: passed.support/v2target still matches the pinned source commit.No production signing, package/container publishing, or release was run.
Checklist
No new runtime behavior is introduced; migrated Hidi tests now live in the destination repository.
Versions applicability
This PR changes only source
support/v2. Sourcemainretains Hidi pending independent acceptance of microsoft/OpenAPI.NET.OData#884;support/v1is out of scope.See the contributing guidelines for more information about how patches are applied across multiple versions.
Additional Notes
Publisher handoff gate: keep this PR in draft and do not merge until destination release-resource authorization and gated build/sign/package readiness are validated. The source remains the publisher until this cleanup is accepted through normal branch policies. Destination Hidi publishing remains disabled; this PR does not enable it, configure auto-merge, bypass policies, or perform a live release.
The coordinator registered destination Azure DevOps definition 759,
Hidi(OpenAPI.NET.OData), targeting the acceptedsupport/v2branch and.azure-pipelines/hidi-release.yml. Production publishing remains hard-disabled. Its first gated queue validation failed before execution because the 1ES template forbids checkout in thepublish_containerrelease job. A destination-only follow-up fixes that release-template issue; release-template validation, resource authorization, and actual gated build/sign/package artifact validation remain prerequisites for accepting this cleanup. No source-cleanup code change is required for that destination blocker.The existing
build.cmd/build.shreferences to the oldMicrosoft.OpenApi.Readersproject name predate this cleanup and are deliberately unchanged. Validation uses the current solution and core/YAML project paths.