Skip to content

refactor(hidi): remove migrated v2 tool resources - #3109

Merged
Vincent Biret (baywet) merged 2 commits into
support/v2from
gavinbarron-hidi-v2-source-cleanup
Oct 9, 2026
Merged

Vincent Biret (baywet) merged 2 commits into
support/v2from
gavinbarron-hidi-v2-source-cleanup

Conversation

@gavinbarron

@gavinbarron Gavin Barron (gavinbarron) commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Pull Request

Description

Remove the active Hidi resources from OpenAPI.NET's support/v2 branch after the history-preserving destination migration was accepted in microsoft/OpenAPI.NET.OData#883.

The destination PR merged normally at 516f5b58f2f3d86901d7da8f171e4c08a52c5edc. This cleanup is based on source 1344a43fb823fea5b48d78e2aca4e3a1eff9221a; it does not rewrite source history or change library APIs or package versions.
The migration coordinator verified the canonical imported commit abd668c6 and all 1,199 shared rewritten history objects are reachable on the destination branch.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): Remove migrated Hidi source/build/release resources; retain the library infrastructure.

Related Issue(s)

Follow-up to microsoft/OpenAPI.NET.OData#883.

Changes Made

  • Delete both Hidi project trees (including their fixtures), the Hidi-only root Dockerfile, and install-tool.ps1.
  • Remove Hidi solution, build-script, CodeQL, editor, core-test ProjectReference, and Hidi-only friend-assembly entries. Keep the shared signing key, all remaining library/test projects, historical changelog entries, and attribution.
  • Remove Hidi packaging, executable/container deployment, container-only RepoFiles artifacts/variables, and the GitHub release-edit job whose only assets were Hidi executables. Keep core/YAML packing and both ESRP signing steps. Select only Microsoft.OpenApi.[0-9]*.nupkg for core publishing instead of deleting other packages; preserve the separate YAML reader deployment and its dependency on core.
  • Redirect Hidi usage/contribution documentation to the destination support/v2 branch.

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • All existing tests pass

The coordinator executed the .NET and package checks in this worktree before committing and pushing 67c832d1c85dbea8ca519971b01ff15a2f7e385c.

  • dotnet build Microsoft.OpenApi.slnx -c Release -v quiet: passed with 0 warnings and 0 errors.
  • dotnet test --solution Microsoft.OpenApi.slnx -c Release --no-build -v minimal: passed, 1,508/1,508 remaining core/readers tests. The original source baseline passed 1,562 tests; the difference is exactly the 54 migrated Hidi tests.
  • dotnet pack src\Microsoft.OpenApi\Microsoft.OpenApi.csproj -c Release --no-build -o C:\Users\gavinbarron\.copilot\session-state\c631d217-9378-4cee-8c7e-761043ff3ae5\files\source-v2-cleanup-packages --include-symbols --include-source /p:SymbolPackageFormat=snupkg: passed.
  • dotnet pack src\Microsoft.OpenApi.YamlReader\Microsoft.OpenApi.YamlReader.csproj -c Release --no-build -o C:\Users\gavinbarron\.copilot\session-state\c631d217-9378-4cee-8c7e-761043ff3ae5\files\source-v2-cleanup-packages --include-symbols --include-source /p:SymbolPackageFormat=snupkg: passed.
  • Fresh pack output contains only Microsoft.OpenApi.2.12.2.nupkg, Microsoft.OpenApi.2.12.2.snupkg, Microsoft.OpenApi.YamlReader.2.12.2.nupkg, and Microsoft.OpenApi.YamlReader.2.12.2.snupkg; no Hidi package.
  • go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.7 -shellcheck= -pyflakes= .github\workflows\codeql-analysis.yml: passed.
  • git diff --check: passed.
  • PowerShell ConvertFrom-Json on all three .vscode JSONC files, XML checks of every remaining solution project and ProjectReference, and PowerShell AST parsing of all five embedded pipeline scripts: passed.
  • PyYAML baseline/current pipeline comparison: passed; all remaining build, signing, pack, feed, trigger, and YAML deployment settings are preserved. Seven core/YAML/Hidi/symbol-package selector cases, including stable and prerelease versions: passed.
  • Destination documentation URL and merged destination PR verified with GitHub API; source support/v2 target still matches the pinned source commit.

No production signing, package/container publishing, or release was run.

Checklist

  • My code follows the code style of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

No new runtime behavior is introduced; migrated Hidi tests now live in the destination repository.

Versions applicability

  • My change applies to the version 1.X of the library, if so PR link:
  • My change applies to the version 2.X of the library, if so PR link: this PR
  • My change applies to the version 3.X of the library, if so PR link:
  • I have evaluated the applicability of my change against the other versions above.

This PR changes only source support/v2. Source main retains Hidi pending independent acceptance of microsoft/OpenAPI.NET.OData#884; support/v1 is out of scope.

See the contributing guidelines for more information about how patches are applied across multiple versions.

Additional Notes

Publisher handoff gate: keep this PR in draft and do not merge until destination release-resource authorization and gated build/sign/package readiness are validated. The source remains the publisher until this cleanup is accepted through normal branch policies. Destination Hidi publishing remains disabled; this PR does not enable it, configure auto-merge, bypass policies, or perform a live release.

The coordinator registered destination Azure DevOps definition 759, Hidi(OpenAPI.NET.OData), targeting the accepted support/v2 branch and .azure-pipelines/hidi-release.yml. Production publishing remains hard-disabled. Its first gated queue validation failed before execution because the 1ES template forbids checkout in the publish_container release job. A destination-only follow-up fixes that release-template issue; release-template validation, resource authorization, and actual gated build/sign/package artifact validation remain prerequisites for accepting this cleanup. No source-cleanup code change is required for that destination blocker.

The existing build.cmd/build.sh references to the old Microsoft.OpenApi.Readers project name predate this cleanup and are deliberately unchanged. Validation uses the current solution and core/YAML project paths.

Follow accepted OpenAPI.NET.OData support/v2 import PR883. Retain core/YAML builds, signing, packaging and history; point hidi documentation to its new home. Publishing handoff remains gated pending destination official pipeline onboarding.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: c631d217-9378-4cee-8c7e-761043ff3ae5
@github-code-quality

github-code-quality Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall line coverage in commit c6717bb in the gavinbarron-hidi-v2-... branch is 24%. The line coverage in commit c719c42 in the support/v2 branch is 32%.

Show a line coverage summary of the most impacted files.
File support/v2 c719c42 gavinbarron-hidi-v2-... c6717bb +/-
/home/runner/wo...Deserializer.cs 81% 0% -81%
/home/runner/wo...pyReferences.cs 63% 13% -50%
/home/runner/wo...ilterService.cs 82% 41% -41%
/home/runner/wo...piJsonReader.cs 100% 72% -28%
/home/runner/wo...s/OpenApiTag.cs 100% 72% -28%
/home/runner/wo...piComponents.cs 99% 91% -8%
_/src/Verify/At...fierSettings.cs 62% 55% -7%
/home/runner/wo...Deserializer.cs 99% 92% -7%
_/src/Verify/Na...fierSettings.cs 32% 45% +13%
/home/runner/wo...piTestAssert.cs 0% 90% +90%

Updated October 09, 2026 14:48 UTC

Comment thread .azure-pipelines/ci-build.yml
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
@baywet
Vincent Biret (baywet) marked this pull request as ready for review October 9, 2026 14:48
@baywet
Vincent Biret (baywet) requested a review from a team as a code owner October 9, 2026 14:48
@baywet
Vincent Biret (baywet) enabled auto-merge (squash) October 9, 2026 14:48
@baywet
Vincent Biret (baywet) merged commit c8e64dc into support/v2 Oct 9, 2026
13 of 16 checks passed
@baywet
Vincent Biret (baywet) deleted the gavinbarron-hidi-v2-source-cleanup branch October 9, 2026 14:50
@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants