Repository navigation
fix: support reinitializing OpenApiOperation.Tags to null and custom comparers - #3116
Open
Austin (AustinAviv) wants to merge 2 commits into
Open
Austin (AustinAviv) wants to merge 2 commits into
Austin (AustinAviv) wants to merge 2 commits into
Conversation
…comparers Align OpenApiOperation.Tags setter and copy constructor with OpenApiDocument.Tags to avoid silently ignoring null assignments and to preserve custom equality comparers or sorted sets.
There was a problem hiding this comment.
🟡 Changes recommended
Immutable-set behavior lacks coverage, and the sorted-set test does not verify comparer preservation.
2 open findings
What changed in this PR
Fixes operation tag resetting and preserves custom set semantics.
Changes:
- Allows resetting
OpenApiOperation.Tagsto null. - Preserves custom comparers, sorted sets, and immutable sorted sets.
- Adds regression tests for most updated behaviors.
| File | Description |
|---|---|
src/Microsoft.OpenApi/Models/OpenApiOperation.cs |
Updates tag assignment and copying behavior. |
test/Microsoft.OpenApi.Tests/Models/OpenApiOperationTests.cs |
Adds tag setter and copy-constructor tests. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| HashSet<OpenApiTagReference> tags when tags.Comparer != EqualityComparer<OpenApiTagReference>.Default => value, | ||
| SortedSet<OpenApiTagReference> => value, | ||
| #if NET | ||
| ImmutableSortedSet<OpenApiTagReference> => value, |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| new HashSet<OpenApiTagReference>(value, OpenApiTagComparer.Instance); | ||
| _tags = value switch | ||
| { | ||
| HashSet<OpenApiTagReference> tags when tags.Comparer != EqualityComparer<OpenApiTagReference>.Default => value, |
| Tags = operation.Tags != null ? new HashSet<OpenApiTagReference>(operation.Tags) : null; | ||
| Tags = operation.Tags switch | ||
| { | ||
| HashSet<OpenApiTagReference> tags when tags.Comparer != EqualityComparer<OpenApiTagReference>.Default => new HashSet<OpenApiTagReference>(tags, tags.Comparer), |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aligns OpenApiOperation.Tags setter and copy constructor with OpenApiDocument.Tags so that assigning
ull resets the tags property, and custom equality comparers or sorted sets are retained instead of being forced into OpenApiTagComparer.Instance.
Type of Change
Related Issue(s)
Fixes #3115
Changes Made
Testing
Checklist
Versions applicability