Repository navigation
Validate bonus configuration limits - #104
Merged
Merged
Conversation
Warn when bonus thresholds fall outside the recommended range or cannot be reached because of study and worker HIT limits. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The validator raises KeyError when a previously optional worker HIT limit is omitted, preventing study generation.
1 open issue
What changed in this PR
This PR adds bonus-setting warnings to study generation, checking recommended thresholds and whether study or worker HIT limits make the quantity bonus unreachable.
Changes:
- Extracts bonus validation into a reusable warning helper.
- Reports inconsistent HIT limits and unreachable bonus thresholds.
- Adds parameterized warning tests and updates an existing test configuration.
| File | Description |
|---|---|
| tests/test_master_script.py | Adds warning cases and supplies a worker HIT limit in an existing fixture. |
| src/master_script.py | Adds bonus-setting validation and prints its warnings during study generation. |
Review effort: Balanced
Apply the existing method-specific worker HIT defaults when validating bonus settings, avoiding failures for configurations that omit the optional limit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Vishak Gopal (vishakg)
approved these changes
Oct 22, 2026
Vishak Gopal (vishakg)
approved these changes
Oct 22, 2026
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Warn when bonus thresholds fall outside the recommended range or cannot be reached because of study and worker HIT limits.