Repository navigation
Configure environment comparison threshold - #105
Open
Babak (babaknaderi) wants to merge 1 commit into
Open
Babak (babaknaderi) wants to merge 1 commit into
Babak (babaknaderi) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in the focused validation and propagation changes; tests were not executed.
No open issues 🎉
What changed in this PR
Makes the environment comparison pass threshold configurable, keeping HIT app screening and result analysis aligned. This replaces #90’s implementation while preserving the default threshold of 2.
Changes:
- Validates
cmp_pass_thresholdas an integer from 1 through 4. - Propagates the threshold into shared HIT app configuration and all four analyzer templates.
- Adds tests for defaults, invalid values, and analyzer configuration rendering.
| File | Description |
|---|---|
tests/test_master_script.py |
Tests threshold validation and analyzer output. |
src/master_script.py |
Validates and propagates the configured threshold. |
src/configurations/master.cfg |
Documents the setting and its default. |
src/assets_master_script/pp835_result_parser_template.cfg |
Uses the configured threshold for PP.835 analysis. |
src/assets_master_script/p804_result_parser_template.cfg |
Uses the configured threshold for P.804 analysis. |
src/assets_master_script/dcr_ccr_result_parser_template.cfg |
Uses the configured threshold for DCR/CCR analysis. |
src/assets_master_script/acr_result_parser_template.cfg |
Uses the configured threshold for ACR analysis. |
.gitattributes |
Disables text normalization for analyzer configuration templates. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supersedes #90 with a clean implementation based on the current
masterbranch.