Feat/2748 paginated seed browsing - #2989
Open
Jackson Severino da Rocha (jacksonsr451) wants to merge 7 commits into
Open
Jackson Severino da Rocha (jacksonsr451) wants to merge 7 commits into
Jackson Severino da Rocha (jacksonsr451) wants to merge 7 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements #2748 by adding typed, read-only APIs for browsing and retrieving logical seed examples from existing seed memory.
This builds on the dataset identity and count contract introduced in #2762 and follows the browsing semantics discussed with Roman Lutz (@romanlutz) in #2748.
What changed
date_addedof the complete logical example, descending, with logical-example ID as the tie-breaker.prompt_group_idas the logical-example identity, falling back to the persisted seed ID for ungrouped records.%and_treated as literal characters.GET /api/datasets/{selection_key}/seedsGET /api/datasets/{selection_key}/seeds/{example_id}is_jinja_templateso browsing can distinguish templates without inferring template state from parameters.MemoryInterface.get_seeds()behavior.Safety and side-effect behavior
Browsing does not:
Named browsing selections are resolved from datasets already represented in seed memory. A provider-only dataset that has not been persisted to memory is therefore not treated as browseable by these endpoints; this avoids provider/file loading during a read-only browsing request.
List previews also avoid exposing absolute filesystem paths or credential-bearing URLs.
Fixes #2748
Tests and Documentation
Added and expanded contract coverage across the Memory, service, persistence, and HTTP layers.
Coverage includes:
%and_text searches;Final focused validation:
git diff --check: passedAzure SQL integration was also validated against a real Azure SQL database after the SQL/schema corrections:
The final HTTP/service changes did not modify the SQL query, schema, or migration behavior after that Azure SQL validation.
JupyText was not run because this change does not modify notebooks or JupyText-managed documentation/examples.