Repository navigation
Tolerate hydration count drift in status estimates - #2146
Draft
Tyrie Vella (tyrielv) wants to merge 4 commits into
Draft
Tyrie Vella (tyrielv) wants to merge 4 commits into
Tyrie Vella (tyrielv) wants to merge 4 commits into
Conversation
…back Record typed count availability, partial observations, validation failures, and phase outcomes. Correlate health commands with cached and fallback calculations through explicit payload identifiers and a compatible IPC extension. Keep count semantics and wait behavior unchanged. Add unit and functional tests for the diagnostic contract, serialization, and compatibility. Assisted-by: GPT-6.1 Sol Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
…t tests Preserve cached summaries and circuit-breaker counts when configuration reads fail. Preserve cancellation policy while recording cancellation origin. Separate command outcome from calculation outcome and name the heartbeat cache-state point sample explicitly. Pin IPC state integers and add regression tests for source-loader orchestration, failed phases, worker timeouts, cache snapshots, real command paths, and collector payloads. Assisted-by: GPT-6.1 Sol Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Poll the structured cache state before checking disabled and available results. Filesystem background readiness does not guarantee that the hydration refresh passed its backoff. Keep the deadline bounded and retain the final completion record on failure. Add functional test cases with zero-second and five-second cache backoff. Keep product behavior unchanged. Assisted-by: GPT-6.1 Sol Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Accept complete nonnegative observations across different count populations. Share estimated display and preserve raw diagnostics without changing database records or cache lookup budgets. Assisted-by: GPT-6.1 Sol Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and Context
Hydration status adds placeholder and modified-path counts, then compares those sums with index-based totals. These counts describe different populations. New paths and retained folders after branch switches can exceed the current totals without a calculation failure. The CLI and cached response currently reject those results.
This draft depends on #2144. The initial diff includes the parent commits because the parent source branch exists only in a fork. After #2144 merges, this PR can retain only the follow-up change.
Changes
n/awhen a positive sum has no denominator.