Skip to content

unix: Avoid open() in file_id() #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Leonard Hecker (lhecker) merged 2 commits into from
Oct 7, 2026
Merged

unix: Avoid open() in file_id() #983

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5bd249
unix: Avoid open() in file_id()
lhecker Oct 7, 2026
7841c49
Merge imports
lhecker Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions crates/edit/src/sys/unix.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
use std::ffi::{c_char, c_int, c_void};
use std::fs::File;
use std::mem::{self, ManuallyDrop, MaybeUninit};
use std::os::fd::{AsRawFd as _, FromRawFd as _};
use std::os::fd::FromRawFd as _;
use std::os::unix::fs::MetadataExt as _;
use std::path::Path;
use std::ptr::{self, NonNull, null_mut};
use std::{io, time};
Expand Down Expand Up @@ -389,23 +390,17 @@ fn set_tty_nonblocking(nonblock: bool) {

#[derive(Clone, PartialEq, Eq)]
pub struct FileId {
st_dev: libc::dev_t,
st_ino: libc::ino_t,
dev: u64,
ino: u64,
}

/// Returns a unique identifier for the given file by handle or path.
pub fn file_id(file: Option<&File>, path: &Path) -> io::Result<FileId> {
let file = match file {
Some(f) => f,
None => &File::open(path)?,
let metadata = match file {
Some(file) => file.metadata()?,
None => std::fs::metadata(path)?,
};

unsafe {
let mut stat = MaybeUninit::<libc::stat>::uninit();
check_int_return(libc::fstat(file.as_raw_fd(), stat.as_mut_ptr()))?;
let stat = stat.assume_init();
Ok(FileId { st_dev: stat.st_dev, st_ino: stat.st_ino })
}
Ok(FileId { dev: metadata.dev(), ino: metadata.ino() })
}

unsafe fn load_library(name: *const c_char) -> io::Result<NonNull<c_void>> {
Expand Down
Loading