Repository navigation
fix: set close-on-exec on pty fds in the parent process - #986
Open
Nick Darvey (NickDarvey) wants to merge 1 commit into
Open
Nick Darvey (NickDarvey) wants to merge 1 commit into
Nick Darvey (NickDarvey) wants to merge 1 commit into
Conversation
The master from forkpty and posix_openpt, and the master and slave from openpty, had no FD_CLOEXEC flag. Each process the host spawned later inherited the fds of all open terminals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014RWxuaKXi4UMzaXW8C5Yuv
Nick Darvey (NickDarvey)
changed the title
Author
|
@microsoft-github-policy-service agree |
Nick Darvey (NickDarvey)
marked this pull request as ready for review
October 6, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The master from forkpty and posix_openpt, and the master and slave from openpty, had no FD_CLOEXEC flag. Each process the host spawned later inherited the fds of all open terminals.