Repository navigation
chore(docker): update base image to ubuntu 26.04 - #2185
Open
Hermsi1337 wants to merge 3 commits into
Open
Hermsi1337 wants to merge 3 commits into
Hermsi1337 wants to merge 3 commits into
Conversation
Select the tarball via TARGETARCH, since uname -p returns unknown on 26.04, and extract it on the build platform. Closes #2184
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2184
ubuntu:26.04TARGETARCHinstead ofuname -p. On 26.04uname -preturnsunknown, so arm64 would have gotten the x64 tarball$BUILDPLATFORM, so the tarball is extracted natively, not under QEMU. The final stage is still built per target platformARCHbuild arg. Neither workflow sets it, and withTARGETARCHpicking the tarball it could combine an arm64 base with x64 binaries.--platformis now the only way to pick the architectureTested with the v1.28.1 release tarballs: arm64 and amd64 images both start with the right arch (
mw --versionshowslinux-arm64/linux-x64), andmw project listagainst the API works on both. The CI path (only the linux-x64 tarball,PKG_SOURCE=dist) builds and runs too.This touches the same lines of the Dockerfile as #2183, whichever goes in second needs a small rebase.
openssh-clientandrsyncinstall fine on 26.04 (OpenSSH 10.2, rsync 3.4.1).The builder now fails with
unsupported architecture: <arch>for anything but amd64/arm64 instead of silently packing the x64 binary (e.g.--platform linux/s390xused to build an image that crashed on start).