Repository navigation
feat(illumina-sample-sheet): require BCL Convert version and pipeline from the caller - #96
Merged
Merged
Conversation
…ud analysis https://mlllab.atlassian.net/browse/AE-5676 🤖 Generated with Claude Code
Code Coverage OverviewLanguages: PHP PHP / code-coverage/phpunitThe overall line coverage in commit 336f223 in the Show a line coverage summary of the most impacted files.
Updated |
New advisories on league/flysystem 1.x and zbateson/mail-mime-parser leave no installable orchestra/testbench for PHP < 8.1. Both are dev-only, pulled in through orchestra/testbench. 🤖 Generated with Claude Code
fischerl
commented
Oct 12, 2026
| "advisories": { | ||
| "ignore": [ | ||
| "laravel/framework" | ||
| "laravel/framework", |
Contributor
Author
There was a problem hiding this comment.
Neue Security Advisories blockieren die Dev-Installation unter PHP 7.4 und 8.0: league/flysystem 1.x (über laravel/framework 8) bei 7.4 und 8.0, zbateson/mail-mime-parser < 3.0.6 (über spatie/laravel-ray) bei 7.4. Beide sind nur Dev-Abhängigkeiten.
… analysis Defaults stay on 4.1.23, so releasing this changes no existing sample sheet. Callers switch by passing the software version and the matching pipeline URN. 🤖 Generated with Claude Code
fischerl
changed the title
dhaupt88
reviewed
Oct 12, 2026
| public function __construct() | ||
| private string $cloudSoftwareVersion; | ||
|
|
||
| public function __construct(string $cloudSoftwareVersion = BclConvertSoftwareVersion::V4_1_23) |
Contributor
There was a problem hiding this comment.
Keine Defaults verwenden. Lieber vom User eine konkrete Entscheidung erzwingen
dhaupt88
approved these changes
Oct 12, 2026
fischerl
changed the title
… from the caller The library no longer decides which BCL Convert version a sample sheet uses. BclConvertSettingsSection requires the software version and CloudSettingsSection requires the BCL Convert pipeline URN. BclConvertSoftwareVersion and CloudSettingsSection::BCL_CONVERT_PIPELINE are removed. Released as a minor version: nemo-api is the only consumer and adapts with the bump. 🤖 Generated with Claude Code
fischerl
force-pushed
the
AE-5676-bclconvert-4-4-10
branch
from
October 12, 2026 13:28
3de098a to
336f223
Compare
fischerl
changed the title
dhaupt88
approved these changes
Oct 12, 2026
fischerl
marked this pull request as ready for review
October 12, 2026 13:50
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 12, 2026
## [6.16.0](v6.15.0...v6.16.0) (2026-10-12) ### Features * **illumina-sample-sheet:** require BCL Convert version and pipeline from the caller ([#96](#96)) ([f3a4190](f3a4190))
|
🎉 This PR is included in version 6.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AE-5676
NovaSeq X cloud analysis sample sheets reference the deprecated BCL Convert 4.1.23.
The caller now passes the BCL Convert version and pipeline URN, so nemo-api can move to 4.4.10, proven in runs #10165 and #10166.
Both sections require their value, the version constants are gone: released as a minor version
BclConvertSettingsSectionrequires the software version, for cloud and local analysis alike.CloudSettingsSectionrequires the BCL Convert pipeline URN.BclConvertSoftwareVersionandCloudSettingsSection::BCL_CONVERT_PIPELINEare removed, since the versions now live in nemo-api.nemo-api is the only consumer, so this ships as 6.16.0 and laravel-utils (
^5.2 || ^6) needs no change.Version and URN must match, the library does not check that.
BCL Convert 4.4 writes CSV reports instead of HTML: left for downstream
The output format change only affects pipelines that parse demux reports, not this library's sample sheet generation.
New advisories block the PHP 7.4 and 8.0 dev installs, so they are ignored
league/flysystem1.x (vialaravel/framework8) blocks PHP 7.4 and 8.0,zbateson/mail-mime-parser< 3.0.6 (viaspatie/laravel-ray) blocks PHP 7.4.Both are dev-only.
Deployment: nemo-api switches in one follow-up MR
The nemo-api MR bumps
mll-lab/php-utilsto^6.16and passes 4.4.10 with its URN for NovaSeq X cloud and 4.4.6 for i100 local analysis.It stays draft until the TWIST EF2.0 validation passes.
🤖 Generated with Claude Code