Repository navigation
fix(core): keep resumption options off cancellation notifications - #2649
LizunovSergey wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: c9c5481 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
3445994 to
88277f1
Compare
|
Rebased onto The conflict was with the
|
88277f1 to
71b750b
Compare
f9115a5 to
c9c5481
Compare
|
Rebased onto I also moved the changeset from |
Fixes #2646.
Root cause
When a legacy-era request was aborted,
Protocolreused the original request's full transport options fornotifications/cancelled. If that request carried aresumptionToken,StreamableHTTPClientTransportinterpreted the cancellation send as a resume operation, swallowed the notification, and opened a resumed GET instead of posting the cancellation.Fix
relatedRequestIdon the cancellation send so request correlation is preserved.resumptionTokenoronresumptiontokento the cancellation notification.@modelcontextprotocol/core.Validation
pnpm --filter @modelcontextprotocol/core-internal test: 69 files, 1,434 tests passed.pnpm lint:allpassed.