Repository navigation
feat(canary): support LLMService targets and protect experiment arms - #108
Open
primowenjoy wants to merge 4 commits into
Open
primowenjoy wants to merge 4 commits into
primowenjoy wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does and why
Canary experiments can select LLMService production targets while preserving HelmRelease support. Model service list/detail now identify experiment arms, link to the owning experiment using namespace/name/UID, and disable independent upgrade, rollback, SLO edits and uninstall. Canary arm details link back to the actual child service. Missing or inconsistent ownership remains protected and never links to a replacement experiment of the same name.
The deployment-plan view includes final
canary-systemand autoscale layers, matching Swiss effective-value precedence.The experiment overview uses readable English/Chinese field labels and lifecycle descriptions instead of raw API field names. Chinese users see labels such as 服务状态, 访问路径 and 全部组就绪时间; generation explicitly identifies the applied/latest configuration versions. Historical experiments retain their last-observed-status explanation.
Design and coordinated changes
Final migration design. Backend enforcement requires Swiss #39; experiment UID and target checks require canaryd #4. Operator lifecycle and target guard: operator #8.
How it was tested
npm run typecheck,npm test(64 files, 544 tests),npm run build, andnpm run build:swisspassed. New cases cover disabled arm write actions, preserved read actions and UID-based linking after same-name recreation. Tests also retain ordinary service and uninstalling service behavior.Manual browser validation with two CPU Mock arms confirmed owner links, disabled arm mutations, enabled ordinary-service upgrade/uninstall actions, and token/TTFT metrics after 80 successful streaming requests.
The disposable experiment was stopped through the UI; child resources and the experiment route were cleaned up while its metric snapshot and the production Mock service were retained.
The final branch passed
npm run typecheck, the full frontend suite (544 tests), andnpm run build. The overview change was deployed to the test environment; both Console replicas became ready. Chrome validation on an existing stopped experiment confirmed translated fields and phase values, immediate English/Chinese switching, unchanged recorded values, and the final Chinese label layout. The browser language was restored to Chinese.Which issue(s) this PR fixes
No separate issue for the overview wording correction; coordinated design and implementation PRs are linked above.
Checks
npm run typecheck && npm test && npm run buildinweb/Notes for reviewers
Only the final design in the Canary plugin repository is maintained; intermediate development documents are excluded. Kubernetes admission and SLO/configuration drift tracking are separate follow-ups.
Release note