Repository navigation
build: cross-compile the multi-arch image instead of emulating it - #24
Merged
Merged
Conversation
The manager is pure Go, so the builder stage now runs on the build platform and cross-compiles for TARGETOS/TARGETARCH; only the distroless runtime stage is per-target and it has no RUN steps. The arm64 image therefore needs no QEMU. Drop docker/setup-qemu-action from the release workflow (and its actions.lock pin), and let docker-buildx use the Dockerfile directly now that it already carries --platform=$BUILDPLATFORM. Co-authored-by: aceforeverd <11715200+aceforeverd@users.noreply.github.com>
aceforeverd
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manager is pure Go, so the arm64 image doesn't need QEMU. Same approach as modelsphere/console#107.
FROM --platform=$BUILDPLATFORM ${GO_IMAGE}and cross-compiles withCGO_ENABLED=0 GOOS=$TARGETOS GOARCH=$TARGETARCH. Only the distroless runtime stage is per-target, and it has noRUNsteps, so nothing runs under emulation.docker/setup-qemu-action(buildx stays), and drop its pin fromactions.lock(regenerated withgh actions-lock).docker-buildxused to sed--platform=${BUILDPLATFORM}into aDockerfile.cross. The Dockerfile has that flag now, so the target builds fromDockerfiledirectly instead of adding the flag twice.Verified locally on an amd64 host with no binfmt/QEMU handlers registered:
docker buildx build --platform linux/amd64,linux/arm64 .succeeds (linux/amd64->arm64builder step), andfilereports the binaries asx86-64andARM aarch64.go build ./...passes.