Skip to content

refactor(mfmodel): remove unused package_extension in register_package - #2871

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:deadcode
Oct 19, 2026
Merged

wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:deadcode

Conversation

@wpbonelli

Copy link
Copy Markdown
Member

dead since #1425

The variable has been dead since d5fca7a (modflowpy#1425), when auto-generated
filenames switched to package_type plus MFFileMgmt.unique_file_name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wpbonelli wpbonelli added this to the 3.11.1 milestone Oct 19, 2026
@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.8%. Comparing base (556c088) to head (7a510c1).
⚠️ Report is 246 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2871      +/-   ##
===========================================
+ Coverage     55.5%    73.8%   +18.2%     
===========================================
  Files          644      659      +15     
  Lines       124135   132503    +8368     
===========================================
+ Hits         68947    97808   +28861     
+ Misses       55188    34695   -20493     
Files with missing lines Coverage Δ
flopy/mf6/mfmodel.py 57.1% <ø> (-23.8%) ⬇️

... and 585 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli
wpbonelli merged commit 3904a45 into modflowpy:develop Oct 19, 2026
23 checks passed
@wpbonelli
wpbonelli deleted the deadcode branch October 19, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant