Skip to content

Bug 2050411 - Handle null values in data without further recursion #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
badboy merged 2 commits into from
Jun 29, 2026
Merged

Bug 2050411 - Handle null values in data without further recursion #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
089cba1
Update schema
badboy Jun 29, 2026
2f24bd9
Handle null values in data without further recursion
badboy Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 48 additions & 2 deletions functions/schema/glean.1.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,43 @@
"name": {
"type": "string"
},
"session": {
"additionalProperties": false,
"description": "Session metadata attached to this event. Absent for out-of-session events and events from before sessions were introduced.",
"properties": {
"event_seq": {
"description": "Per-session event counter, reset at each new session.",
"minimum": 0,
"type": "integer"
},
"session_id": {
"description": "The unique UUID for this session.",
"type": "string"
},
"session_sample_rate": {
"description": "The sampling rate in effect for this session.",
"maximum": 1.0,
"minimum": 0.0,
"type": "number"
},
"session_seq": {
"description": "Monotonically increasing session counter, persisted across restarts.",
"minimum": 0,
"type": "integer"
},
"session_start_time": {
"description": "Wall-clock timestamp at session start (RFC 3339). Absent on events from before this field was introduced.",
"type": "string"
}
},
"required": [
"session_id",
"session_seq",
"event_seq",
"session_sample_rate"
],
"type": "object"
},
"timestamp": {
"minimum": 0,
"type": "integer"
Expand Down Expand Up @@ -869,8 +906,8 @@
},
"description": "Map of metric identifiers (category.name) to boolean values indicating whether the metric is enabled",
"propertyNames": {
"maxLength": 61,
"pattern": "^[a-z_][a-z0-9_]{0,29}(\\.[a-z_][a-z0-9_]{0,29})+$",
"maxLength": 111,
"pattern": "^[a-z_][a-z0-9_\\.]+$",
"type": "string"
},
"type": "object"
Expand All @@ -886,6 +923,15 @@
"type": "string"
},
"type": "object"
},
"session_sample_rate": {
"description": "Remote override for the session sampling rate (0.0–1.0).",
"maximum": 1.0,
"minimum": 0.0,
"type": [
"number",
"null"
]
}
},
"type": "object"
Expand Down
6 changes: 6 additions & 0 deletions src/components/ShowRawPing/components/PingSection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ const PingSection = ({ pingSection, header, isNested }) => {
value = value.toString();
}

// Have to convert nulls to a fixed string or else nothing
// is printed in the table.
if (value == null) {
value = "<null>";
}

return (
<tr key={key}>
<td>{key}</td>
Expand Down
4 changes: 2 additions & 2 deletions src/components/ShowRawPing/lib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const getNestedAndNonNestedKeysFromObject = (obj) => {
Object.keys(obj).forEach((key) => {
const value = obj[key];

if (typeof value === 'object') {
if (typeof value === 'object' && value != null) {
nestedKeys.push(key);
} else {
nonNestedKeys.push(key);
Expand All @@ -37,7 +37,7 @@ export const getNestedAndNonNestedKeysFromObject = (obj) => {

/**
* Pad a string to a specified length with a specified character.
*
*
* @param {string} s The original string.
* @param {number} desiredStringLength How long the string should be after padding.
* @param {string} padChar The character to pad the string with.
Expand Down