Repository navigation
Fix SourceNode.children type to include strings - #533
Closed
Hanabi9248 wants to merge 1 commit into
Closed
Hanabi9248 wants to merge 1 commit into
Hanabi9248 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #482.
SourceNode.add()andprepend()store both strings andSourceNodeinstances inchildren, but the declaration only allowsSourceNode[]. This rejects valid string children and lets callers access node methods without narrowing.Change the element type to
SourceNode | string, matching the implementation and the existing chunk parameter types.Verified with TypeScript 5.9.3 (
--strict --noEmit --lib es2015): mixed children and string narrowing fail before this change and pass afterward; node-only access without narrowing and numeric children are rejected. The 18 existing SourceNode runtime tests also pass.