Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indexed maps with a nonzero section line offset currently report an infinite column span where the following section starts on the same generated line. This can make a mapping's reported range include columns owned by the next section.
Apply the line offset before checking the next section's boundary in
generatedPositionFor,allGeneratedPositionsFor, andeachMapping. Keep the first-line column-offset adjustment in section-local coordinates.Add 12 regression and boundary tests covering all three APIs, both the first and later section lines, a next section on a different line, finite spans, and uncomputed terminal spans.
Closes #539
Validation (Node.js 22.22.0):
npm run coverage, repository-wide ESLint, and Prettier on the new test file pass.Implementation and test execution were assisted by Codex.