feat(postgres): expose workload Postgres uses with branches by rbjornstad · Pull Request #560 · nais/api

rbjornstad · 2026-10-14T08:55:41Z

Summary

Change Workload.postgreses to a paginated PostgresUsesConnection for Application and Job.
Each PostgresUse includes envPrefix, effective role, the referenced postgres, and branch as the resolved PostgresBranch.
Resolve explicit branch pins first; otherwise use the observed active branch, falling back to main until an active branch is observed.

Tests

Focused postgres_workloads, postgres_branch_selection, and postgres_branches Lua integration suites.
Postgres domain tests and go test ./internal/graph.
GraphQL generation and Lua formatting.

Copilot

🟢 Approval recommended

The implementation is consistent with existing behavior and has focused coverage for branch selection and error cases.

0 open findings

What changed in this PR

Adds resolved Postgres branch usages to application and job workloads while preserving existing fields.

Changes:

Adds Workload.postgresUsages and supporting models/resolvers.
Centralizes explicit, observed-active, and fallback branch selection.
Covers branch resolution and failure cases with unit and integration tests.

File	Description
`internal/persistence/postgres/queries.go`	Resolves workload Postgres usages and branches.
`internal/persistence/postgres/queries_test.go`	Tests duplicate-use handling.
`internal/persistence/postgres/models.go`	Adds the usage relationship model.
`internal/persistence/postgres/delete_test.go`	Tests resolved usage branches.
`internal/graph/schema/postgres.graphqls`	Exposes the new GraphQL field and type.
`internal/graph/postgres.resolvers.go`	Resolves usages for applications and jobs.
`internal/graph/gengql/root_.generated.go`	Updates generated root schema code.
`internal/graph/gengql/postgres.generated.go`	Adds generated usage serialization.
`internal/graph/gengql/jobs.generated.go`	Adds generated job field handling.
`internal/graph/gengql/applications.generated.go`	Adds generated application field handling.
`integration_tests/postgres_workloads.lua`	Tests workload usage results.
`integration_tests/postgres_branch_selection.lua`	Tests selection and missing-branch behavior.

Files not reviewed (3)

internal/graph/gengql/applications.generated.go: Generated file
internal/graph/gengql/jobs.generated.go: Generated file
internal/graph/gengql/postgres.generated.go: Generated file

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

thokra-nav · 2026-10-14T10:26:46Z

Spørsmål til denne. Skulle vi hatt en uses: WorkloadUsesConnection! hvor vi har et interface eller union for WorkloadUse? (names tbd)

Mtp at flere ting skal inn der, så kanskje vi skal samle det?

rbjornstad · 2026-10-14T11:11:53Z

@thokra-nav Godt poeng. Jeg jobber med saken i rom 5 :D

rbjornstad · 2026-10-14T11:35:03Z

@thokra-nav Oppdatering: jeg fjernet workload-feltet postgreses helt, slik at Workload.uses er den samlede flaten for eksterne ressurser. Team.postgreses og Postgres.workloads er separate felt og er urørt.

Copilot

🟡 Changes recommended

It removes a public field without deprecation and resolves resources outside the requested page.

2 open findings

Files not reviewed (4)

internal/graph/gengql/applications.generated.go: Generated file
internal/graph/gengql/complexity.go: Generated file
internal/graph/gengql/jobs.generated.go: Generated file
internal/graph/gengql/postgres.generated.go: Generated file

🧠 Review effort: Balanced

This reverts commit 4c00cc2.

This reverts commit 401b529.

Copilot

🟡 Changes recommended

The public schema breaks existing clients, omits promised configured fields, and has inconsistent pagination validation.

6 open findings

Files not reviewed (4)

internal/graph/gengql/applications.generated.go: Generated file
internal/graph/gengql/complexity.go: Generated file
internal/graph/gengql/jobs.generated.go: Generated file
internal/graph/gengql/postgres.generated.go: Generated file

🧠 Review effort: Balanced

Copilot

🔵 Needs a closer look

The existing public GraphQL field is changed incompatibly without a deprecated compatibility path.

0 open findings

6 resolved since last review

Files not reviewed (4)

internal/graph/gengql/applications.generated.go: Generated file
internal/graph/gengql/complexity.go: Generated file
internal/graph/gengql/jobs.generated.go: Generated file
internal/graph/gengql/postgres.generated.go: Generated file

🧠 Review effort: Balanced

feat(postgres): expose resolved Postgres usages on workloads

f1746d1

nais-team-app Bot added the graphql-review-required label Oct 14, 2026

rbjornstad requested a balanced review from Copilot October 14, 2026 08:56

Copilot started reviewing on behalf of rbjornstad October 14, 2026 08:56

View session

Copilot AI reviewed Oct 14, 2026

View reviewed changes

rbjornstad marked this pull request as ready for review October 14, 2026 09:03

rbjornstad requested a review from a team as a code owner October 14, 2026 09:03

feat(graphql): add generic workload uses connection

401b529

rbjornstad changed the title ~~feat(postgres): expose resolved Postgres usages on workloads~~ feat(graphql): expose typed workload uses Oct 14, 2026

feat(graphql): remove workload postgreses fields

4c00cc2

rbjornstad requested a balanced review from Copilot October 14, 2026 11:37

Copilot started reviewing on behalf of rbjornstad October 14, 2026 11:38

View session

Copilot AI reviewed Oct 14, 2026

View reviewed changes

Comment thread internal/graph/schema/postgres.graphqls Outdated

Comment thread internal/persistence/postgres/queries.go

rbjornstad added 3 commits October 14, 2026 14:02

Revert "feat(graphql): remove workload postgreses fields"

640a4ab

This reverts commit 4c00cc2.

Revert "feat(graphql): add generic workload uses connection"

75b126d

This reverts commit 401b529.

feat(postgres): expose resolved uses on workloads

d6972dd

rbjornstad changed the title ~~feat(graphql): expose typed workload uses~~ feat(postgres): expose Postgres uses on workloads Oct 14, 2026

thokra-nav reviewed Oct 14, 2026

View reviewed changes

Comment thread internal/graph/schema/postgres.graphqls Outdated

thokra-nav reviewed Oct 14, 2026

View reviewed changes

Comment thread internal/graph/schema/postgres.graphqls Outdated

feat(postgres): expose resolved branches on workload uses

999c3fa

rbjornstad requested a balanced review from Copilot October 14, 2026 13:34

Copilot started reviewing on behalf of rbjornstad October 14, 2026 13:35

View session

Copilot AI reviewed Oct 14, 2026

View reviewed changes

Comment thread internal/graph/schema/postgres.graphqls Outdated

Comment thread internal/graph/postgres.resolvers.go Outdated

Comment thread internal/graph/schema/postgres.graphqls

Comment thread internal/graph/postgres.resolvers.go Outdated

rbjornstad changed the title ~~feat(postgres): expose Postgres uses on workloads~~ feat(postgres): expose workload Postgres uses with branches Oct 14, 2026

fix(graphql): keep workload Postgres resolver generation stable

78fcd78

christeredvartsen approved these changes Oct 14, 2026

View reviewed changes

nais-team-app Bot removed the graphql-review-required label Oct 14, 2026

rbjornstad added 2 commits October 14, 2026 16:16

feat(graphql): add docs

ddd635c

fix(postgres): resolve only paged workload uses

756d7cb

rbjornstad requested a balanced review from Copilot October 14, 2026 14:40

Copilot started reviewing on behalf of rbjornstad October 14, 2026 14:41

View session

Copilot AI reviewed Oct 14, 2026

View reviewed changes

rbjornstad merged commit 620e68b into main Oct 15, 2026
14 checks passed

rbjornstad deleted the feat/workload-postgres-usages branch October 15, 2026 06:40

Navigation Menu

Repository navigation

feat(postgres): expose workload Postgres uses with branches - #560

feat(postgres): expose workload Postgres uses with branches#560
rbjornstad merged 10 commits into
mainfrom
feat/workload-postgres-usages

rbjornstad commented Oct 14, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

thokra-nav commented Oct 14, 2026

Uh oh!

rbjornstad commented Oct 14, 2026 •

edited

Loading

Uh oh!

rbjornstad commented Oct 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

rbjornstad commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tests

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

thokra-nav commented Oct 14, 2026

Uh oh!

rbjornstad commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rbjornstad commented Oct 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rbjornstad commented Oct 14, 2026 •

edited

Loading

rbjornstad commented Oct 14, 2026 •

edited

Loading