🗃️ Make archiving tables/applications a personal option by AndyScherzinger · Pull Request #2476 · nextcloud/tables

AndyScherzinger · 2026-04-12T12:08:03Z

Resolves partially Make archiving tables/views a personal option #2125

🖼️ Screenshots

Archived categories	Archive app	Archive table	Unarchive app	Unarchive table

The original ticket #2125 defined tables and views, while this PR tacked tables and apps. Given a clear view on how archived views should get displayed this could be added as a follow-up PR to not make this PR grow in review-size and complexity.

Summary

This change replaces the existing single-user global archived flag on tables with a two-layer per-user model: an owner-level flag on the entity and a new tables_archive_user table that stores individual user overrides, so archive state is resolved per-user at read time. When an owner archives a table or application, it is automatically treated as archived for every user with access, but any of those users may override this for themselves; an owner unarchiving resets the state for everyone by clearing all per-user overrides.
The existing tables_tables.archived column is repurposed from a simple global toggle into the owner-level signal, and the database migration converts all currently-archived tables into owner-archived entries to preserve existing data without disruption.
Application (context) archiving is introduced as a completely new capability end-to-end: covering database schema, entity, service, API endpoints, routes, and frontend navigation - while table archiving is substantially reworked from a simple owner toggle into the full per-user propagation system.
A new ArchiveService centralizes all business logic for both resource types, four new API endpoints are split across ApiTablesController and ContextController following existing naming conventions, and the frontend gains archive/unarchive actions in both navigation item menus alongside a new collapsible "Archived applications" section mirroring the already-existing "Archived tables" section.

⚠️ Beware

The database migration only covers the owner and direct user shares, not groups, etc. since they can't be resolved directly via SQL (think teams/groups). So in these cases archived tables would resurface until manually archived by the respective user. Also there is no cleanup for teams/groups, if a user is taken out of a team, the archive meta-info would not get deleted. Only simple but confusing way around it would be to prevent archiving/unarchiving for tables/apps where a user is neither the owner nor a user-share receiver. Expensive alternative would be a housekeeping job checking all these archive bits periodically, but that also sounds expensive with little use. Else we would need to consume a team/group changes event and check if some cleanup is needed. WDYT?

🏁 Checklist

⛑️ Tests (unit and/or integration) are included or not needed
🔙 Backport requests are created or not needed: /backport to stableX.X
📅 Milestone is set
🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

The content of this PR was partly or fully generated using AI

jancborchardt

Looks generally nice, 2 details

I’d say to use outline icons instead of filled for both cases, archiving and unarchiving
In the cases of "Archive app" and "Unarchive app", the sorting of actions in the menu is off. We always recommend the destructive action (Delete) to be the very last, and then the next most destructive like Archive could be directly above it.

Add the tables_archive_user table and the contexts.archived column, the UserArchive entity and mapper, and the archived flag on the Table and Context entities. Non-owner archive decisions are stored as per-user override rows, owner decisions live on the entity flag. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Owner archiving toggles the shared entity flag inside a transaction and clears every per-user override; non-owners store or drop a personal override. The service also resolves the per-user flag onto entity collections and migrates overrides when ownership is transferred. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

…ices Enrich read paths with the per-user resolved archived flag, add archive/unarchive, keep the state consistent across ownership transfer and deletion, hide archived contexts from the navigation, and expose the archived field in the API response definitions. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Add the v2 table and context archive/unarchive endpoints (rate-limited, permission-checked, contexts addressed via the string typeParam) and their routes, resolve the per-user state in the single-item GET endpoints, and leave the archived state unchanged on partial updates through API v1 and the occ command. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Remove stale archive overrides when a share is deleted, a group or circle membership ends, a receiver is deleted, or a user account is removed. Per-user access re-checks are handed to a background job so an unrelated request does not scale with the number of override holders. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Add archive/unarchive actions to the table and context navigation items, a collapsible archived-applications section, and the matching store actions that guard against a missing local item. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Cover the archive service and cleanup service, the mapper, the archive/unarchive controller endpoints, the background job, and the archive/unarchive UI flows for tables and applications. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

enjeck

It seems like a lot of the docblock descriptions are wrong, which is confusing. Or am i misunderstanding them?

enjeck · 2026-10-19T00:35:28Z

+			while ($shareRow = $shareResult->fetchAssociative()) {
+				$receiverId = $shareRow['receiver'];
+				if ($receiverId !== $ownerId) {
+					$inserted += $this->upsertArchiveRecord($checkQb, $insertQb, $receiverId, $tableId);


This adds a personal archived=true row for each direct user share of an already archived table. So why do we need postSchemaChange()?

enjeck · 2026-10-19T00:38:14Z

+	 * For every row in `tables_tables` where `archived = true`, insert one
+	 * `tables_archive_user` record for the owner and one for each direct


this is wrong?

enjeck · 2026-10-19T00:41:03Z

+			$tableId = (int)$tableRow['id'];
+			$ownerId = $tableRow['ownership'];
+
+			// The owner deliberately gets no override row: the entity-level


This comment explains why the owner gets no personal row. The same reason applies to the direct share recipients below, whose rows would also keep the table archived after the owner unarchives, right. therefor, we could we skip the recipients too, which leaves postSchemaChange() with nothing to do?

enjeck · 2026-10-19T00:44:03Z

+	/**
+	 * [api v2] Archive a table for the requesting user
+	 *
+	 * Owners archive the table for all users (clears per-user overrides).


This seems misleading, since the owner archive path does not clear personal rows. ArchiveService::archiveForUser() only sets tables_tables.archived. Could it say that the owner sets the default, and that users who made their own choice keep it?

enjeck · 2026-10-19T00:44:40Z

+	/**
+	 * [api v2] Unarchive a table for the requesting user
+	 *
+	 * Owners unarchive the table for all users (clears per-user overrides).


similar as at https://github.com/nextcloud/tables/pull/2476/changes#r4309477879 . The owner archive path does not clear personal rows.

enjeck · 2026-10-19T00:45:58Z

+	/**
+	 * [api v2] Archive a context for the requesting user
+	 *
+	 * Owners archive the context for all users (clears per-user overrides).


similar as at https://github.com/nextcloud/tables/pull/2476/changes#r4309477879 . The owner archive path does not clear personal rows.

enjeck · 2026-10-19T00:46:17Z

+	/**
+	 * [api v2] Unarchive a context for the requesting user
+	 *
+	 * Owners unarchive the context for all users (clears per-user overrides).


similar as at https://github.com/nextcloud/tables/pull/2476/changes#r4309477879 . The owner archive path does not clear personal rows.

enjeck · 2026-10-19T00:47:27Z

+	 *
+	 * An owner toggles the entity-level flag and clears every per-user
+	 * override, so all users inherit the owner's choice. Anyone else only


Suggested change

*

* An owner toggles the entity-level flag and clears every per-user

* override, so all users inherit the owner's choice. Anyone else only

*

* An owner toggles the entity-level flag,

* so all users inherit the owner's choice. Anyone else only

enjeck · 2026-10-19T00:49:29Z

+		} catch (Exception $e) {
+			$this->logger->error($e->getMessage(), ['exception' => $e]);
+		}
+		return array_values(array_filter($contexts, static fn (Context $context) => !$context->isArchived()));


This hides archived applications from the Nextcloud app menu. The “Show in app list” checkbox still shows for archived applications, but toggling it has no visible effect. Should the menu hide or disable that checkbox while the application is archived?

enjeck · 2026-10-19T00:52:54Z

+		// flag leaves the archived state unchanged instead of unarchiving
+		$archived = $input->getOption('archived') ? true : null;


So there is now no way to unarchive a table with occ tables:rename ?

AndyScherzinger added enhancement New feature or request 2. developing Work in progress labels Apr 12, 2026

AndyScherzinger changed the title ~~Personal archiving option~~ 🗃️ Make archiving tables/applications personal option Apr 12, 2026

AndyScherzinger force-pushed the feat/2125/personal-archiving-option branch 5 times, most recently from 008f4f3 to 0e2bbdc Compare April 12, 2026 15:34

AndyScherzinger changed the title ~~🗃️ Make archiving tables/applications personal option~~ 🗃️ Make archiving tables/applications a personal option Apr 12, 2026

AndyScherzinger force-pushed the feat/2125/personal-archiving-option branch 2 times, most recently from d3fce3e to fd235a6 Compare April 12, 2026 18:56

AndyScherzinger marked this pull request as ready for review April 12, 2026 19:36

AndyScherzinger requested review from blizzz and enjeck as code owners April 12, 2026 19:36

AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 12, 2026

AndyScherzinger requested review from benjaminfrueh, jancborchardt, marcoambrosini and samin-z April 15, 2026 22:19

jancborchardt previously requested changes Apr 28, 2026

View reviewed changes

jancborchardt added this to 🖍 Design team Apr 28, 2026

jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Apr 28, 2026

AndyScherzinger force-pushed the feat/2125/personal-archiving-option branch from fd235a6 to ba16212 Compare April 28, 2026 13:13

ChristophWurst reviewed Apr 28, 2026

View reviewed changes

Comment thread lib/Db/UserArchive.php Outdated

ChristophWurst reviewed Apr 28, 2026

View reviewed changes

Comment thread lib/Db/UserArchiveMapper.php Outdated

AndyScherzinger force-pushed the feat/2125/personal-archiving-option branch 4 times, most recently from 840a1ab to 086aad3 Compare April 28, 2026 20:06

AndyScherzinger added the 3. to review Waiting for reviews label Sep 5, 2026

AndyScherzinger force-pushed the feat/2125/personal-archiving-option branch 12 times, most recently from 36faeb9 to 40aec24 Compare September 12, 2026 10:55

enjeck force-pushed the feat/2125/personal-archiving-option branch from 40aec24 to 94ce7a1 Compare September 17, 2026 05:24

enjeck reviewed Sep 17, 2026

View reviewed changes

Comment thread lib/Service/TableService.php Outdated

Comment thread lib/Service/TableService.php Outdated

Comment thread tests/unit/Controller/ApiTablesControllerArchiveTest.php

AndyScherzinger force-pushed the feat/2125/personal-archiving-option branch 2 times, most recently from 340f674 to 794e3e8 Compare September 17, 2026 13:27

AndyScherzinger requested a review from enjeck September 17, 2026 15:34

AndyScherzinger force-pushed the feat/2125/personal-archiving-option branch 2 times, most recently from 2fb9108 to 42d3fa5 Compare October 4, 2026 08:39

AndyScherzinger added 8 commits October 19, 2026 00:41

chore(archive): regenerate OpenAPI spec and TypeScript types

408f6b8

Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

AndyScherzinger force-pushed the feat/2125/personal-archiving-option branch from 42d3fa5 to 49bf195 Compare October 18, 2026 22:44

enjeck reviewed Oct 19, 2026

View reviewed changes

		* For every row in `tables_tables` where `archived = true`, insert one
		* `tables_archive_user` record for the owner and one for each direct

		// flag leaves the archived state unchanged instead of unarchiving
		$archived = $input->getOption('archived') ? true : null;

Conversation

AndyScherzinger commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🖼️ Screenshots

Summary

⚠️ Beware

🏁 Checklist

🤖 AI (if applicable)

Uh oh!

jancborchardt left a comment • edited by AndyScherzinger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

enjeck left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AndyScherzinger commented Apr 12, 2026 •

edited

Loading

jancborchardt left a comment •

edited by AndyScherzinger

Loading