[mahibi]

not yet tested!

• Symptom

  • After leaving a chat (Back or Home), the signaling websocket kept receiving messages for that room and no push notifications arrived. The server still had a session for the user in the room.

• Cause 1: rejoin right after leaving (fixed in f9461f957)

  • When the leave REST call completes, ChatViewModel.leaveRoom() resets getCapabilitiesViewState to GetCapabilitiesStartState.
  • conversationFlow re-emits when lastReadMessage or lastCommonReadMessage changes. The latter was added in 61ba4e8 and comes e.g. from the conversation list's room sync. That emission turns into GetCapabilitiesInitialLoadState.
  • ChatActivity stays STARTED after onPause until onStop. After finish(), onStop can come up to ~10 s later, so its observer called joinRoomWithPassword() and joined the room again (REST + websocket).
  • With Home, the value was delivered in onStart. If nothing emitted while the app was in the background, the chat did not rejoin at all on return.

• Fix 1

  • The room is only joined while ChatActivity is resumed. A join requested between onPause and onResume is deferred to onResume.
  • A left room is always rejoined in onResume, independent of conversation emissions.
  • No second REST join is started while one is running.

  Cause 2: cancelled join (fixed in 3c76ebf6e)

  • ChatViewModel.onPause() disposed a join that was still running. The server could still create the session, while onPause saw no valid session and did not leave. The session stayed until the server timed it out.

• Fix 2

  • The join keeps running across onPause. If the chat was left in the meantime, the ViewModel leaves via REST (in appScope, so it also works after Back) as soon as the join completes, and the join is not reported to the activity.
  • Resuming before the join completes cancels the pending leave.
  • The "join running" state lives in the ViewModel, so a rotation doesn't start a second join.

• Not changed

  • WebSocketInstance still keeps currentRoomToken on leave. It doesn't affect this bug: the session is cleared on leave, and the server's reply to the leave clears the token.
  • The GetCapabilitiesStartState reset in ChatViewModel.leaveRoom() is still there and could be removed as a follow-up.

• How to test

  • Open a chat and leave it with Back, then with Home. After leaveRoom completed there should be no sessionID was not valid -> joinRoom and no Sending join room message via websocket.
  • After Home, returning should join exactly once, after onResume.
  • Leave a chat right after opening it, while the join is still running. You should see join in progress -> leaving room once it completes, then joinRoom completed after the chat was left -> leaving the room again.
  • Check that pushes for that room arrive again after leaving.

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

• The content of this PR was partly or fully generated using AI

[mahibi]

oh that was coincidence..
i had this as a prompt for 2 weeks and finally found the time for it but it seems @ToteMeiSter also found this problem and seems to address it with #6909

It will take a closer look on monday. So i might close my PR in favor of #6909

[github-actions]

📱 QA build

Download	app-qa-debug.apk
QR code	Open the QR code for this download
Commit	c22770f
Version	6916
Available until	7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

[mahibi]

closing in favor of #6909