Repository navigation
fix: keep CI Go tooling identical across stages - #58
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe main and guide-site build workflows now pin Go to version 1.26.10. Their setup steps include comments about executable identity verification and runner caches. ChangesGo CI version
Priority: ⬆️ High Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to
|
|
Prepare completed. Workflow evidence. This is the candidate assessment, not independent policy or deployment approval. Prepare: passCommit: 8076c7f · Platform: 1.1.4-PullRequest58.1 · Target: canary Selection: v1.1.4-PullRequest58.1; resolved: v1.1.4-PullRequest58.1; OGP ring: preview.
Guide statusNo guide fixes identified by these checks. Artifact and live-site checks run in later stages. |
|
Preview deployed for commit 8076c7f: https://blue-field-06cea8c03-58.westeurope.6.azurestaticapps.net/. Live verification follows in Actions. |
Separate Prepare and Build jobs can select different Go patch versions from runner-local caches when setup-go receives
>=1.24.5. OGP's tool-identity check correctly rejected the v1.1.3 release: the first attempt used 1.26.9 then 1.26.10, and the fresh retry reversed those versions.Pin all three CI setup-go steps to 1.26.10 so the platform build and guide-site stages select the same executable. Preserve tool-identity checks, action tags, product minimums, triggers, secrets and deployment behavior. Dependency-lock regeneration leaves the lockfile unchanged.
Validation: full root acceptance exited 0: 578 tests passed, three existing skips; extracted packages, reference preview/production and both packaged contributor workflows passed; independent read-only diff review completed with no findings. The pinned version is present in the official setup-go manifest. Hosted Prepare/Build and the release pipeline must confirm the actual outcome before publication.
Summary by CodeRabbit