You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
PropertyCallbackInfo::This() deleted in v8 14.6 #1014
v8::PropertyCallbackInfo::Holder() has been renamed to HolderV2 (chromium-issue)
I'm not an expert on this subject and the fact that it's 2 separate deprecations occurring at the same time is confusing me as to the proper way to go. It seems like Holder was deprecated in favor of This which was deprecated in favor of HolderV2.
Our addon can switch from This to HolderV2 trivially but cloudflare has taken issue with this change. I've made a fork to naively delete nan::PropertyCallbackInfo::This and make nan::PropertyCallbackInfo::Holder() call v8::PropertyCallbackInfo::HolderV2() but I don't know if this covers all the expected cases, hence the issue.
Activity
kkoopa commentedon Apr 29, 2026
This is unfortunate. I also do not know what the best solution, if any, would be. This requires further study.
agracio commentedon May 6, 2026
Should be resolved by #1016