Skip to content

vfs: unflag - #66318

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mcollina:unflag-node-vfs
Oct 15, 2026
Merged

vfs: unflag#66318
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mcollina:unflag-node-vfs

Conversation

@mcollina

@mcollina mcollina commented Sep 26, 2026

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

nodejs-github-bot commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/ffi
  • @nodejs/security-wg
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 26, 2026
Renegade334
Renegade334 reviewed Sep 26, 2026
View reviewed changes
Comment thread lib/internal/process/pre_execution.js Outdated
@mcollina
mcollina marked this pull request as ready for review September 29, 2026 14:21
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 29, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 29, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78075/

@codecov

codecov Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.47%. Comparing base (29bd740) to head (149064e).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #66318   +/-   ##
=======================================
  Coverage   90.47%   90.47%           
=======================================
  Files         791      791           
  Lines      277245   277247    +2     
  Branches    53310    53316    +6     
=======================================
+ Hits       250834   250848   +14     
+ Misses      16811    16809    -2     
+ Partials     9600     9590   -10
Files with missing lines Coverage Δ
lib/internal/vfs/file_system.js 99.63% <100.00%> (-0.01%) ⬇️
lib/vfs.js 100.00% <100.00%> (ø)
src/node.cc 79.58% <100.00%> (+0.33%) ⬆️
src/node_options.cc 81.69% <ø> (-0.08%) ⬇️
src/node_options.h 95.65% <100.00%> (ø)

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ljharb

ljharb commented Sep 30, 2026

Copy link
Copy Markdown
Member

Before unflagging, since we now own npmjs.com/vfs, can we allow 'vfs' as a specifier to import/require this code module?

@mcollina mcollina added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 6, 2026
@github-actions github-actions Bot added resume-ci-failed Resuming CI with the resume-ci label failed and requires manual intervention. and removed resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. labels Oct 10, 2026
@github-actions

github-actions Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Failed to resume CI

✖ Refusing to resume CI job 78075: its approved commit does not match the current PR HEAD

Full Auto Start CI output 
�[36m⠋�[39m Validating Jenkins credentials
�[36m⠋�[39m Validating Jenkins credentials
✔  Jenkins credentials valid
�[36m⠙�[39m Looking for CI runs for pull request 66318
�[36m⠙�[39m Looking for CI runs for pull request 66318
�[36m⠙�[39m Getting PR from nodejs/node/pull/66318
�[36m⠙�[39m Getting reviews from nodejs/node/pull/66318
�[36m⠙�[39m Getting comments from nodejs/node/pull/66318
✔  Found PR CI job 78075
�[36m⠹�[39m Querying data for job/node-test-pull-request/78075/
�[36m⠹�[39m Querying data for job/node-test-pull-request/78075/
�[36m⠹�[39m Querying API for job/node-test-pull-request/78075/
✔  Build data downloaded
�[36m⠹�[39m Checking whether PR CI job 78075 can be resumed
�[36m⠹�[39m Checking whether PR CI job 78075 can be resumed
✔  Jenkins offers a Resume build action
�[36m⠹�[39m Checking failures against changed PR files
�[36m⠹�[39m Checking failures against changed PR files
�[36m⠸�[39m Querying data for job/node-test-pull-request/78075/
�[36m⠸�[39m Querying API for job/node-test-pull-request/78075/
✔  Build data downloaded
�[36m⠸�[39m Querying failures of job/node-test-commit/92887/
�[36m⠸�[39m Querying failures of job/node-test-commit/92887/
�[36m⠸�[39m Querying API for job/node-test-commit-linux/73647/
�[36m⠸�[39m Querying API for job/node-test-commit-smartos/68829/
�[36m⠸�[39m Querying API for job/node-test-commit-linux-containered/59583/
�[36m⠸�[39m Querying console text for job/node-test-commit-custom-suites-freestyle/50355/
�[36m⠼�[39m Querying API for job/node-test-commit-linux/nodes=fedora-last-latest-x64/73647/
�[36m⠼�[39m Querying API for job/node-test-commit-linux/nodes=fedora-latest-x64/73647/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_icu_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl111_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl30_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl35_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl40_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_shared_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_smallicu_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_withoutintl_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_withoutssl_x64/59583/
�[36m⠼�[39m Querying API for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_zlib_x64/59583/
�[36m⠴�[39m Querying API for job/node-test-commit-smartos/nodes=smartos23-x64/68829/
�[36m⠴�[39m Querying console text for job/node-test-commit-linux/nodes=fedora-last-latest-x64/73647/
�[36m⠴�[39m Querying console text for job/node-test-commit-linux/nodes=fedora-latest-x64/73647/
�[36m⠴�[39m Querying console text for job/node-test-commit-smartos/nodes=smartos23-x64/68829/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_icu_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl111_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl30_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl35_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl40_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_shared_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_smallicu_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_withoutintl_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_withoutssl_x64/59583/
�[36m⠦�[39m Querying console text for job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_zlib_x64/59583/
✔  Data downloaded
✔  No changed PR files found in available failure details
   ✖  Refusing to resume CI job 78075: its approved commit does not match the current PR HEAD

View workflow run

@mcollina mcollina added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. resume-ci-failed Resuming CI with the resume-ci label failed and requires manual intervention. labels Oct 10, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 10, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78294/

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 12, 2026
@github-actions github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Failed to start CI

   ℹ  Existing CI run found: https://ci.nodejs.org/job/node-test-pull-request/78294/
   ✖  Refusing to start a potentially duplicate CI job. Resume CI by adding the "resume-ci" label to the PR, or run: ncu-ci resume https://github.com/nodejs/node/pull/66318
Full Auto Start CI output 
�[36m⠋�[39m Getting reviews from nodejs/node/pull/66318
�[36m⠋�[39m Getting commits from nodejs/node/pull/66318
�[36m⠙�[39m Validating Jenkins credentials
�[36m⠙�[39m Validating Jenkins credentials
✔  Jenkins credentials valid
�[36m⠹�[39m Getting comments from nodejs/node/pull/66318
�[36m⠸�[39m Querying data for job/node-test-pull-request/78294/
�[36m⠸�[39m Querying data for job/node-test-pull-request/78294/
�[36m⠸�[39m Querying API for job/node-test-pull-request/78294/
✔  Build data downloaded
   ℹ  Existing CI run found: https://ci.nodejs.org/job/node-test-pull-request/78294/
   ✖  Refusing to start a potentially duplicate CI job. Resume CI by adding the "resume-ci" label to the PR, or run: ncu-ci resume https://github.com/nodejs/node/pull/66318

View workflow run

@mcollina mcollina removed the request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. label Oct 12, 2026
@mcollina mcollina added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 12, 2026
@github-actions github-actions Bot removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 12, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78332/

@mcollina
vfs: unflag
149064e 
Enable node:vfs by default. --no-experimental-vfs disables node:vfs
exposure and --vfs-load.

Assisted-by: pi
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 14, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 14, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78384/

@mcollina mcollina added commit-queue PRs queued for automated landing through the Commit Queue. semver-minor PRs that contain new features and should be released in the next minor version. labels Oct 15, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 49ad950 into nodejs:main Oct 15, 2026
71 checks passed
@nodejs-github-bot

nodejs-github-bot commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Landed in 49ad950

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renegade334 Renegade334 Renegade334 left review comments
@ShogunPanda ShogunPanda ShogunPanda approved these changes
@jasnell jasnell jasnell approved these changes

Assignees

No one assigned

Labels

lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mcollina @nodejs-github-bot @ljharb @ShogunPanda @jasnell @Renegade334