Skip to content

doc: correct QuicStream direction and id types - #66687

Open
kisnner26 wants to merge 1 commit into
nodejs:mainfrom
kisnner26:doc/quic-stream-types
Open

kisnner26 wants to merge 1 commit into
nodejs:mainfrom
kisnner26:doc/quic-stream-types

Conversation

@kisnner26

Copy link
Copy Markdown

Fixes the documented nullability of QuicStream.direction and clarifies that QuicStream.id is only null while a stream is pending.

Refs: #66686.

Validated against the current getters and test/parallel/test-quic-session-stream-lifecycle.mjs.

Signed-off-by: Kisnner Obando <kisnnerobando7@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. quic Issues and PRs related to the QUIC transport implementation. labels Oct 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

Caution

AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentscan:mixed-signals doc Issues and PRs related to Node.js documentation. quic Issues and PRs related to the QUIC transport implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants