Skip to content

tools: add read-only access in nix-changes.yml - #66691

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:nix-changes-ro
Oct 14, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:nix-changes-ro

Conversation

@aduh95

@aduh95 aduh95 commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Without it, the workflow fails on private forks.

Without it, the workflow fails on private forks.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 12, 2026

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 13, 2026
@nodejs-github-bot
nodejs-github-bot merged commit e39f2e8 into nodejs:main Oct 14, 2026
32 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in e39f2e8

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 14, 2026
@aduh95
aduh95 deleted the nix-changes-ro branch October 14, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants