Repository navigation
Docs: fix quic stream nullability - #66701
Closed
aliyasyeddd wants to merge 3 commits into
Closed
aliyasyeddd wants to merge 3 commits into
aliyasyeddd wants to merge 3 commits into
Conversation
Signed-off-by: aliya syed <mahaboobaliya03@gmail.com>
Signed-off-by: aliya syed <mahaboobaliya03@gmail.com>
…/aliyasyeddd/node into docs/fix-quic-stream-nullability
Collaborator
|
Review requested:
|
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
Member
|
Hi @aliyasyeddd, thanks for contributing, but I'm afraid there's already an open PR for this: #66687. In future I'd recommend checking for open PRs on issues before opening a new one - if you open the issue you can see the links to other PRs that reference the issue there. It's OK if an old PR has stalled (been left stuck for months) but that's not the case here. I'll close this as a duplicate now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corrects the documented nullability of
Stream.directionand clarifies thatStream.idreturnsnullonly while a stream is pending, not after destruction.Fix
Updates the
doc/api/quic.mddescriptions to accurately reflect the current behavior of both properties.Relation
Fixes #66686