Skip to content

Docs: fix quic stream nullability - #66701

Closed
aliyasyeddd wants to merge 3 commits into
nodejs:mainfrom
aliyasyeddd:docs/fix-quic-stream-nullability
Closed

aliyasyeddd wants to merge 3 commits into
nodejs:mainfrom
aliyasyeddd:docs/fix-quic-stream-nullability

Conversation

@aliyasyeddd

Copy link
Copy Markdown

Description

Corrects the documented nullability of Stream.direction and clarifies that Stream.id returns null only while a stream is pending, not after destruction.

Fix

Updates the doc/api/quic.md descriptions to accurately reflect the current behavior of both properties.

Relation

Fixes #66686

Signed-off-by: aliya syed <mahaboobaliya03@gmail.com>
Signed-off-by: aliya syed <mahaboobaliya03@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. quic Issues and PRs related to the QUIC transport implementation. labels Oct 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

@aliyasyeddd aliyasyeddd changed the title Docs/fix quic stream nullability Docs: fix quic stream nullability Oct 13, 2026
@pimterry

Copy link
Copy Markdown
Member

Hi @aliyasyeddd, thanks for contributing, but I'm afraid there's already an open PR for this: #66687. In future I'd recommend checking for open PRs on issues before opening a new one - if you open the issue you can see the links to other PRs that reference the issue there. It's OK if an old PR has stalled (been left stuck for months) but that's not the case here. I'll close this as a duplicate now.

@pimterry pimterry closed this Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to Node.js documentation. quic Issues and PRs related to the QUIC transport implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc: QuicStream.direction / id is incorrectly documented as nullable

3 participants