Repository navigation
Conversation
The test reserved a local port by listening on port 0 and closing the server, then reused that port as `localPort`. Another test running in parallel can take the port in between, which makes both the IPv6 and the IPv4 bind fail with EADDRINUSE. Move the test to sequential and use `common.PORT`, the same approach used for test-https-connect-localport in 0f7e24a. Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-10-10.md Assisted-by: a closed-source coding agent Signed-off-by: nhinata <bounceback0505@gmail.com>
nodejs-github-bot
added
needs-ci
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-net-autoselectfamily-local-portfailed in CI (reliability report 2026-10-10):https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_icu_x64/59770/console
Both the IPv6 and IPv4 attempts fail at
bindwith EADDRINUSE. The test gets a free port by listening on port 0 and closing it, so another test can take that port before the connection binds to it.I moved it from
test/parallel/totest/sequential/and usedcommon.PORT, liketest-https-connect-localport(0f7e24a).On macOS with net/http tests running in the background,
it failed once in 1000 runs before this change and 0 times after.
cc @mcollina
I used an AI coding agent to help investigate the reliability reports and write the repro scripts.
I ran and checked the results above myself.