Repository navigation
Conversation
Contributor
|
Caution AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66720 +/- ##
==========================================
- Coverage 92.82% 90.49% -2.34%
==========================================
Files 422 791 +369
Lines 194297 277208 +82911
Branches 30063 53305 +23242
==========================================
+ Hits 180359 250847 +70488
- Misses 13613 16759 +3146
- Partials 325 9602 +9277
🚀 New features to boost your workflow:
|
When the proxy URL uses https://, the agents connected to the proxy with tls.connect() using only the host and port, so no SNI was sent and proxies that pick their certificate by SNI could answer with a certificate that fails verification. Set servername to the proxy host when it is not an IP address, matching undici. Signed-off-by: lazerg <lazerg2@gmail.com> Assisted-by: Claude Code
lazerg
force-pushed
the
fix/issue-66718-proxy-sni
branch
from
October 14, 2026 10:39
b47826b to
5d37cfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the proxy URL uses
https://, the http and https agents connect to the proxy withtls.connect()using only the host and port fromProxyConfig, so no SNI is sent. Proxies that choose their certificate by SNI then answer with their default one, which can fail verification. This setsservernameto the proxy host when it isn't an IP address, the same way undici does forfetch().Fixes: #66718