Skip to content

build: fix gtest integration - #66735

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:gtest-shared
Oct 15, 2026
Merged

build: fix gtest integration#66735
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:gtest-shared

Conversation

@aduh95

@aduh95 aduh95 commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Mistake in #66626, I forgot to name the named param, resulting in Package node_shared_gtest_libraries was not found in the pkg-config search path warning when running configure

@aduh95
build: fix gtest integration
6701471 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Oct 14, 2026
@aduh95 aduh95 added fast-track PRs proposed for a shorter-than-standard waiting period before landing. and removed build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Oct 14, 2026
@github-actions

github-actions Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 14, 2026
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 14, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 14, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78398/

@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 14, 2026
@nodejs-github-bot
nodejs-github-bot merged commit df214ab into nodejs:main Oct 15, 2026
99 checks passed
@nodejs-github-bot

nodejs-github-bot commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Landed in df214ab

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 15, 2026
@aduh95
aduh95 deleted the gtest-shared branch October 15, 2026 13:28
@aduh95 aduh95 added lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x labels Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes
@gurgunday gurgunday gurgunday approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing. lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95 @nodejs-github-bot @panva @gurgunday