Repository navigation
[10.0] Own newly cloned connections - #4056
Merged
Merged
Conversation
Backport the complete fix from #3565 (98c429c). Fixes #1814. Co-authored-by: Marcus Bernander <marcusber@users.noreply.github.com> Co-authored-by: Shay Rojansky <roji@roji.org> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 42616e25-7eb1-4f77-a0e7-874b9426b276
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport the complete fix from #3565 (98c429c) to
hotfix/10.0.4, including both source commits.CloneWithand both supplied-connection/data-sourceCreateAdminConnectionpaths now own their newly cloned connections. The ownership-awareWithConnectionoverload clears any previously configured data source so the supplied connection takes precedence.Includes focused regression coverage for data-source replacement with either ownership choice, synchronous/asynchronous disposal of admin and cloned wrappers, and continued usability of caller-owned connections/data sources. Applies unchanged without dependency updates or unrelated database-creator/
Existschanges.Fixes #1814.
Validation:
dotnet test test/EFCore.PG.Tests/EFCore.PG.Tests.csproj --filter FullyQualifiedName~NpgsqlRelationalConnectionTest --verbosity minimal— 31 passed, 0 failed, 0 skipped on .NET SDK 10.0.300 with this branch's VSTest configuration.