Repository navigation
[8.0] Fix ownership of cloned and administrative connections - #4057
Merged
Merged
Conversation
Backport the complete fix from #3565, retaining synchronous cloning and the existing 8.0 connection cleanup. Co-authored-by: Marcus Bernander <marcusber@users.noreply.github.com> Co-authored-by: Shay Rojansky <roji@roji.org> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 92d45eab-d040-4405-98b3-d3bc2ab14bc8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the complete fix from #3565 (#3565).
Fixes #1814 (#1814).
CloneWithand both data-source/supplied-connectionCreateAdminConnectionbranches own their newly cloned connections.WithConnection(DbConnection?, bool owned)so the supplied connection takes precedence.DbDataSourceproperty and synchronousCloneWith, covering sync/async disposal and preserving caller-owned connections/data sources.No dependency upgrades or unrelated database-existence/cleanup changes.
Validation:
dotnet test test/EFCore.PG.Tests/EFCore.PG.Tests.csproj --no-restore --filter FullyQualifiedName~NpgsqlRelationalConnectionTest --verbosity minimal— 18 passed, 1 pre-existing skip. All 8 regression cases failed before the product fix and passed afterward.