Repository navigation
fix(cli): handle nvm://upgrade toast action - #19
Merged
Merged
Conversation
Toast button was dropped as an unsupported protocol host. Dispatch to sync upgrade --force --release <version>. Refs nvm-windows/nvm#1476 Signed-off-by: Corey Butler <770982+coreybutler@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvm://upgrade?version=from the toast action. Previously that host was treated as firewall and failed.upgrade --releaseto sync.exe so the toasted version is what gets installed (--forcebecause protocol has no console).Fixes the dead toast button in nvm-windows/nvm#1476.
Test plan
go test ./commands ./test/commands -run TestParseUpgradeProtocol|TestCLIUpgradeProtocol