Repository navigation
Tolerate lazy-loaded thumbnails in the image modal tests - #128
Merged
Merged
Conversation
MediaWiki master now defaults `$wgNativeImageLazyLoading` to true (false through REL1_46, changed for T148047), so thumbnails carry `loading="lazy"` and the image modal tests' thumbnail regexes fail on the MW master CI leg. Make the attribute optional, as the patterns already do for `alt=""` and ` /`: `loading` is MediaWiki's markup, which this extension never emits, so the tests accept either form rather than pin the setting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
malberts
marked this pull request as ready for review
October 8, 2026 14:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MediaWiki master now defaults
$wgNativeImageLazyLoadingto true (false through REL1_46, changed for T148047), so thumbnails carryloading="lazy"and the image modal tests' thumbnail regexes fail on the MW master CI leg. Make the attribute optional, as the patterns already do foralt=""and/:loadingis MediaWiki's markup, which this extension never emits, so the tests accept either form rather than pin the setting.Considered, omitted:
$wgNativeImageLazyLoading, not the version, so any setup that sets the flag explicitly would break it.<img>attribute list, so a future core change can break them again; loosening them to what this extension controls is a larger rewrite.