Repository navigation
fix(layout): fail the layout when ELK's thread or child process dies - #66
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
🎉 This PR is included in version 0.6.1-rc.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Merged
Contributor
|
🎉 This PR is included in version 0.6.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Large diagrams lay out with ELK in a Node worker thread, or under Bun in a child process. Three ways that thread or process could die weren't handled:
'error'event: the layout promise never settled, sodeliverhung with no exit code, andservestalled every later rebuild.JSON.parsethrew inside a'close'listener, as an uncaught exception.'error'event that crashed the process.The thread bridge and child runner move into
src/elk-io.ts.threadPortfails pending requests on'exit', andrunChildsettles once and rejects on every failure path, naming the signal when the child is killed. The Bun child path now gets a realdisposethat kills any leftover child. A rejected layout already becomes a clean exit 2 in the CLI. The comment onmainThreadElknow says it is Bun's large-graph host on Windows.How it was checked
test/elk-io.test.tshas 8 cases, using hand-built fake threads and children:'error'event;bun run testpasses (including the 500-node stress case), the Bun smoke still matches the baked layouts, and the deliver determinism smoke passes. Layout output is unchanged.