Skip to content

hotfix: Forecast - #4158

Merged
LKuemmel merged 1 commit into
openWB:masterfrom
seaspotter:hotfix-forecast
Oct 22, 2026
Merged

LKuemmel merged 1 commit into
openWB:masterfrom
seaspotter:hotfix-forecast

Conversation

@seaspotter

Copy link
Copy Markdown
Collaborator

Fixt das Problem das ich mit #4153 reingebracht habe:
Leeren Store beim Zyklus-Split nicht mehr fälschlich publizieren

#3785 (comment)

@LKuemmel
LKuemmel requested review from ndrsnhs and a lite review from Copilot October 22, 2026 06:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

All reviewed changes are covered by regression tests and no unresolved blocking issues were identified.

No open issues 🎉

What changed in this PR

This hotfix prevents empty forecast data from being published before the first successful provider fetch, while preserving the existing today/tomorrow cycle split.

Changes:

  • Defers ForecastValueStore state initialization until forecast data is available.
  • Safely ignores missing state in LoggingValueStore.
  • Adds regression coverage for pre-fetch updates and publication behavior.
File Description
packages/​modules/​common/​store/​_forecast.py Prevents an empty forecast state from being published before the first fetch.
packages/​modules/​common/​store/​_forecast_test.py Tests missing-state handling and safe no-op publishing.
packages/​modules/​common/​configurable_forecast_test.py Verifies updates remain safe before the first forecast fetch.

Review effort: Lite

@LKuemmel
LKuemmel merged commit 6256fe9 into openWB:master Oct 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants