Repository navigation
hotfix: Forecast - #4158
Merged
Merged
hotfix: Forecast#4158
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes are covered by regression tests and no unresolved blocking issues were identified.
No open issues 🎉
What changed in this PR
This hotfix prevents empty forecast data from being published before the first successful provider fetch, while preserving the existing today/tomorrow cycle split.
Changes:
- Defers
ForecastValueStorestate initialization until forecast data is available. - Safely ignores missing state in
LoggingValueStore. - Adds regression coverage for pre-fetch updates and publication behavior.
| File | Description |
|---|---|
packages/modules/common/store/_forecast.py |
Prevents an empty forecast state from being published before the first fetch. |
packages/modules/common/store/_forecast_test.py |
Tests missing-state handling and safe no-op publishing. |
packages/modules/common/configurable_forecast_test.py |
Verifies updates remain safe before the first forecast fetch. |
Review effort: Lite
ndrsnhs
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixt das Problem das ich mit #4153 reingebracht habe:
Leeren Store beim Zyklus-Split nicht mehr fälschlich publizieren
#3785 (comment)