name: Typo bug report
about: Typo in authentication error message (duplicate "Authorization")
title: 'Typo: Duplicate header name in authentication error message'
labels: bug, documentation
assignees: ''
Confirm this is an issue with the Python library and not an underlying OpenAI API
Describe the bug
There is a copy-paste typo in the _validate_headers error message in both the sync and async clients. The message says:
"Authorization or Authorization headers to be explicitly omitted"
But it should mention both supported auth headers: Authorization (Bearer tokens) and api-key (API key auth).
Looking at the X.509 auth code in src/openai/auth/_x509.py:66, the SDK actually checks for api-key, x-api-key, and proxy-authorization headers as well.
Locations
File: src/openai/_client.py
- Sync client, line 664:
raise TypeError(
'"Could not resolve authentication method. Expected either api_key or admin_api_key to be set. Or for one of the `Authorization` or `Authorization` headers to be explicitly omitted"'
)
- Async client, line 1428:
raise TypeError(
'"Could not resolve authentication method. Expected either api_key or admin_api_key to be set. Or for one of the `Authorization` or `Authorization` headers to be explicitly omitted"'
)
Proposed fix
Change the error message to correctly list the auth headers:
raise TypeError(
"Could not resolve authentication method. Expected either api_key or admin_api_key to be set. Or for one of the `Authorization` or `api-key` headers to be explicitly omitted"
)
(Also note the original message has extra leading/trailing double quotes inside the string which is also unnecessary.)
To Reproduce
Call any API method without setting credentials and without explicitly omitting auth headers.
Library version
v2.x latest (main branch)
name: Typo bug report
about: Typo in authentication error message (duplicate "Authorization")
title: 'Typo: Duplicate header name in authentication error message'
labels: bug, documentation
assignees: ''
Confirm this is an issue with the Python library and not an underlying OpenAI API
Describe the bug
There is a copy-paste typo in the
_validate_headerserror message in both the sync and async clients. The message says:But it should mention both supported auth headers:
Authorization(Bearer tokens) andapi-key(API key auth).Looking at the X.509 auth code in
src/openai/auth/_x509.py:66, the SDK actually checks forapi-key,x-api-key, andproxy-authorizationheaders as well.Locations
File:
src/openai/_client.pyProposed fix
Change the error message to correctly list the auth headers:
(Also note the original message has extra leading/trailing double quotes inside the string which is also unnecessary.)
To Reproduce
Call any API method without setting credentials and without explicitly omitting auth headers.
Library version
v2.x latest (main branch)