Repository navigation
Handle Default Responses in response generation #124
Description
Activity
fwiy I just monkeypatched
parser/openapi.pytemporarily with
edit: actually the default was the valid response so for me it ended up beingresponse_from_data(status_code=int(200 if code == 'default' else code)
I think it is atypical
@staticmethod def _add_responses(endpoint: "Endpoint", data: oai.Responses) -> "Endpoint": endpoint = deepcopy(endpoint) for code, response_data in data.items(): + if code == 'default': + continue response = response_from_data(status_code=int(code), data=response_data) if isinstance(response, ParseError): endpoint.errors.append( ParseError( detail=( f"Cannot parse response for status code {code}, " f"response will be ommitted from generated client" ), data=response.data, ) ) continue if isinstance(response, (RefResponse, ListRefResponse)): endpoint.relative_imports.add(import_string_from_reference(response.reference, prefix="...models")) endpoint.responses.append(response) return endpointReacted by Dylan Anthony, Derek Ardolf, Shawn O'Grady, Kristian Brünn, Jeff Robbins, Daniel Schröer and Jon Fuller- added 2 commits that reference this issue
on Feb 11, 2021 - locked and limited conversation to collaborators
on Aug 13, 2023
Describe the bug
In the specifications, default MAY be used as a default response object for all HTTP codes that are not covered individually by the specification.
ValueError: invalid literal for int() with base 10: 'default'
To Reproduce
Sample code from a openapi spec.
Expected behavior
Code should generate a custom ApiResponseError class if default is defined, with content of error being a model of the reference/schema items
OpenAPI Spec File
Sample code from a openapi spec.
Desktop (please complete the following information):