Skip to content

OBPIH-8025 Fix receiving workflow tests - #105

Merged
alannadolny merged 19 commits into
mainfrom
OBPIH-8025
Oct 9, 2026
Merged

alannadolny merged 19 commits into
mainfrom
OBPIH-8025

Conversation

@alannadolny

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

One rollback test still permits asynchronous cleanup to race an unfinished rollback.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Updates and re-enables receiving workflow tests for the current UI and behavior.

Changes:

  • Re-enables previously skipped receiving suites.
  • Updates quantity, sorting, putaway, modal, and table interactions.
  • Adds stronger assertions and page-object helpers.
File Description
validationsOnEditAndReceive.test.ts Updates validation workflows and rollback synchronization.
sortByAlphabeticalOrderAndRemainInputs.test.ts Tests sorting while preserving quantities.
receiveToHoldBin.test.ts Updates hold-bin selection and assertions.
lotExpirySystemUpdateOnReceiving.test.ts Updates lot-expiry modal workflows.
editsInReceiving.test.ts Revises line-editing and validation scenarios.
editOriginalLineQtyTo0.test.ts Updates zero-quantity and product replacement tests.
editBinLocationWhenReceive.test.ts Updates putaway location workflows.
cancelRemainingQty.test.ts Revises cancellation and status assertions.
assertQtyInputs.test.ts Updates split-line quantity persistence tests.
assertCreationOfReceivingBin.test.ts Re-enables receiving-bin coverage.
assertCreationOfGoodsReceiptNote.test.ts Re-enables receipt-note coverage.
assertBinLocationField.test.ts Updates bin-location split-line assertions.
ReceiptsTable.ts Adds receipt-row text lookup.
ReceivingStep.ts Adds putaway and sorting helpers.
CheckStep.ts Updates the back-navigation locator.
ReceivingTable.ts Adds location selection and autofill helpers.
EditModalTable.ts Updates modal fields and row indexing.
EditModal.ts Updates modal locators.
NewAlertPopup.ts Supports configurable button labels.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/tests/receiving/cancelRemainingQty.test.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The functional updates are consistent, with only a minor test-title grammar issue remaining.

Review effort: Balanced
Findings: None

Resolved since last review (1)
Previously missed (1)

In code that hasn't changed since last review

Low severity Clarify test title for the Save & Exit action

src/​tests/​receiving/​assertQtyInputs.test.ts:208

Use “when using Save & Exit” so this test title is grammatically complete and matches the UI action name.

@alannadolny alannadolny self-assigned this Oct 9, 2026
@alannadolny
alannadolny merged commit 206ecb4 into main Oct 9, 2026
1 check passed
@alannadolny
alannadolny deleted the OBPIH-8025 branch October 9, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants